Configurable: remove unused double foreach loop #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fballiano
reviewed
May 24, 2024
| * @var array | ||
| */ | ||
| protected $_prices = []; | ||
|
|
||
| /** | ||
| * Prepared prices | ||
| * | ||
| * @deprecated |
There was a problem hiding this comment.
_resPrices is used on line 167
There was a problem hiding this comment.
but only is set, it is never used (that's why i didn't removed the variables yet)
There was a problem hiding this comment.
@Hanmac true, should the _preparePrice call be removed too?
There was a problem hiding this comment.
I think yeah, but that might be for later MR
|
after reading the code I did a few tests and couldn't see any problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The double
foreachdoes nothing of value inside the Block:$this->_preparePricewhich just does format the price value.$_pricesvariable hasn't been working for 16 years since Magento 1.1 when this file was created.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)