Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable: remove unused double foreach loop #4008

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Configurable: remove unused double foreach loop #4008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions app/code/core/Mage/Catalog/Block/Product/View/Type/Configurable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ class Mage_Catalog_Block_Product_View_Type_Configurable extends Mage_Catalog_Blo
{
/**
* Prices
*
* @deprecated
* @var array
*/
protected $_prices = [];

/**
* Prepared prices
*
* @deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_resPrices is used on line 167

Screenshot 2024-05-24 alle 18 35 15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but only is set, it is never used (that's why i didn't removed the variables yet)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hanmac true, should the _preparePrice call be removed too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yeah, but that might be for later MR

* @var array
*/
protected $_resPrices = [];
Expand Down Expand Up @@ -216,14 +216,7 @@ public function getJsonConfig()
$optionPrices[] = $configurablePrice;
}
}
/**
* Prepare formatted values for options choose
*/
foreach ($optionPrices as $optionPrice) {
foreach ($optionPrices as $additional) {
$this->_preparePrice(abs($additional - $optionPrice));
}
}

if ($this->_validateAttributeInfo($info)) {
$attributes[$attributeId] = $info;
}
Expand Down
Loading