Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento-lts-868 Add .gitignore file #870

Merged
merged 2 commits into from
Dec 25, 2019
Merged

magento-lts-868 Add .gitignore file #870

merged 2 commits into from
Dec 25, 2019

Conversation

kkrieger85
Copy link
Contributor

Fixes #868

Flyingmana
Flyingmana requested changes Dec 15, 2019
View reviewed changes
Copy link
Member

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also allow /package/ to make sure, changes there still get recognized
which means, we also need to prefix the other rules with / to prevent its used for all subdirectories, in case someone adds something persistent there.

@kkrieger85
Copy link
Contributor Author

AFAIK /package/ is only relevant for Magento Connect, which I guess will be removed from OpenMage, doesn't it?

@Flyingmana
Copy link
Member

thats a topic we did not touch yet.

@kkrieger85
Copy link
Contributor Author

@Flyingmana updated file

@Flyingmana Flyingmana merged commit 89adc78 into OpenMage:1.9.4.x Dec 25, 2019
@sreichel sreichel added this to the Release 19.4.1 milestone Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@edannenberg
Add var/.gitignore file
7aace0e 
refs: OpenMage#870
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@edannenberg
Add var/.gitignore file
76d5341 
refs: OpenMage#870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
Release 19.4.1
Development

Successfully merging this pull request may close these issues.

Addition to .gitignore
4 participants
@kkrieger85 @Flyingmana @colinmollenhour @sreichel