Better HTML tagging #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small tweak to make the HTML tagging better by removing an unnecessary <li> tag
|
Why did you move the code like this? Are the two possible situations mutually exclusive? |
|
I find this way better than the regular HTML tagging from the original source. It removes the uneeded use of the li tag twice. It's just a organized version of the same code. |
|
This is just a Magento mirror of the official code and should be an exact copy right? @blopa |
|
You're mixing tabs and spaces. |
|
This should be raised against https://github.com/OpenMage/magento-lts, not here. Can you close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small tweak to make the HTML tagging better by removing an unnecessary