Fix wrong conditionals in scaling loops of rotmg and update BLAS1 tests from netlib #1463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1452, my original fix #1454 was still incorrect. I believe this was caused solely by a copy-paste error inverting the conditionals in the rescaling of dd1,dd2 against GAMSQ.
In addition to the fix, the sblas1 and dblas1 tests are replaced with newer versions from LAPACK 3.8.0 to add the tests for rotm,rotmg and dsdot.