Add support for RISCV64_GENERIC in cmake #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - the values used in the Makefile build are an educated(?) guess for what should work on any RISCV hardware when the build system cannot simply compile and run getarch on the target. (Note to self- eventually we'll want the other RISCV targets in that ridiculously long table too. This PR is an outflow of #3640 (comment) - getting a cross-compile to WEBM working with CMAKE as well). |
|
Thanks! This must have happened in the period where gmail send all github mail to spam, so thats why im so late :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for RISCV64_GENERIC was missing in cmake, so I added support for it.
I am not sure where these values come from, but I copied them from the config.h when using Make.