Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct *args **kwargs typing #6799

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Correct *args **kwargs typing #6799

merged 3 commits into from
Oct 6, 2022

Conversation

kiendang
Copy link
Contributor

Description

Fix #6791

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

shubham3121
shubham3121 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and fix @kiendang 💯 !!

@shubham3121 shubham3121 merged commit c8288e1 into OpenMined:dev Oct 6, 2022
@kiendang kiendang deleted the args-kwargs-typing branch October 6, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham3121 shubham3121 shubham3121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect typing of *args and **kwargs
2 participants
@kiendang @shubham3121