Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of PRRS(Pseudo-Random Random Share) #228

Merged
merged 5 commits into from Jun 12, 2021

Conversation

rasswanth-s
Copy link
Contributor

@rasswanth-s rasswanth-s commented Jun 9, 2021

Description

PRRS (Pseudo-Random Random Share) is implemented such that parties could compute share values of random number.fixes #227 .It is an n-out-of-n sharing for ShareTensor and 2-out-3 sharing for RSTensor.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Checklist

src/sympc/session/session.py Show resolved Hide resolved
src/sympc/session/session.py Show resolved Hide resolved
tests/sympc/session/session_test.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #228 (16fa17a) into main (f2c2804) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 16fa17a differs from pull request most recent head b2f9efa. Consider uploading reports for the commit b2f9efa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          52       52           
  Lines        2261     2202   -59     
  Branches      277      265   -12     
=======================================
- Hits         2071     2017   -54     
+ Misses        133      131    -2     
+ Partials       57       54    -3     
Impacted Files Coverage Δ
src/sympc/protocol/falcon/falcon.py 72.72% <0.00%> (-4.55%) ⬇️
src/sympc/tensor/mpc_tensor.py 87.50% <0.00%> (-0.14%) ⬇️
src/sympc/api.py 100.00% <0.00%> (ø)
src/sympc/session/session.py 100.00% <0.00%> (ø)
src/sympc/tensor/share_tensor.py 95.40% <0.00%> (+0.61%) ⬆️
src/sympc/tensor/replicatedshare_tensor.py 94.23% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c2804...b2f9efa. Read the comment docs.

@rasswanth-s rasswanth-s added the feature Add a new functionality label Jun 10, 2021
@rasswanth-s rasswanth-s changed the title [WIP]Implementation of PRRS(Pseudo-Random Random Share) Implementation of PRRS(Pseudo-Random Random Share) Jun 10, 2021
Copy link
Member

@gmuraru gmuraru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rasswanth-s rasswanth-s added this to the Falcon milestone Jun 11, 2021
Copy link
Member

@Syzygianinfern0 Syzygianinfern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

src/sympc/session/session.py Outdated Show resolved Hide resolved
src/sympc/session/session.py Outdated Show resolved Hide resolved
src/sympc/session/session.py Outdated Show resolved Hide resolved
src/sympc/session/session.py Show resolved Hide resolved
src/sympc/session/session.py Outdated Show resolved Hide resolved
src/sympc/session/session.py Show resolved Hide resolved
Copy link
Member

@Syzygianinfern0 Syzygianinfern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamathhrishi kamathhrishi merged commit 09a62f5 into OpenMined:main Jun 12, 2021
@rasswanth-s rasswanth-s deleted the prrs branch June 12, 2021 15:42
@rasswanth-s rasswanth-s self-assigned this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add a new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correlated Randomness : RandomShare
5 participants