Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABY3 Truncation Protocol -Semihonest #257

Merged
merged 25 commits into from
Jul 1, 2021
Merged

ABY3 Truncation Protocol -Semihonest #257

merged 25 commits into from
Jul 1, 2021

Conversation

rasswanth-s
Copy link
Contributor

@rasswanth-s rasswanth-s commented Jun 26, 2021 •
edited
Loading

Description

Implements the ABY3 truncation algorithm in Falcon.
Addresses part of issue #172

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Checklist

@rasswanth-s rasswanth-s added the feature Add a new functionality label Jun 26, 2021
@rasswanth-s rasswanth-s added this to the Falcon milestone Jun 26, 2021
@rasswanth-s rasswanth-s changed the title [WIP]ABY3 Truncation Protocol -Semihonest ABY3 Truncation Protocol -Semihonest Jun 26, 2021
kamathhrishi
kamathhrishi requested changes Jun 27, 2021
View reviewed changes
Copy link
Contributor

@kamathhrishi kamathhrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

gmuraru
gmuraru reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@gmuraru gmuraru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. I am also ok with merging this as it is now and make some of the fixes (like the one with parallel_execution and shared generator between party 2 and 3 in another PR.

@rasswanth-s rasswanth-s mentioned this pull request Jun 29, 2021
Merged
4 tasks
kamathhrishi
kamathhrishi approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@kamathhrishi kamathhrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just rename two of the unit tests and then you can merge.

@rasswanth-s rasswanth-s requested a review from gmuraru July 1, 2021 04:09
gmuraru
gmuraru approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@gmuraru gmuraru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In rest LGTM! 🚀

@rasswanth-s rasswanth-s merged commit d6411e2 into OpenMined:main Jul 1, 2021
@rasswanth-s rasswanth-s deleted the falcon_truncate branch July 27, 2021 10:03
@rasswanth-s rasswanth-s self-assigned this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamathhrishi kamathhrishi kamathhrishi approved these changes

@gmuraru gmuraru gmuraru approved these changes

@Syzygianinfern0 Syzygianinfern0 Awaiting requested review from Syzygianinfern0

@LaRiffle LaRiffle Awaiting requested review from LaRiffle

@aanurraj aanurraj Awaiting requested review from aanurraj aanurraj is a code owner

Assignees

@rasswanth-s rasswanth-s

Labels
feature Add a new functionality
Projects
None yet
Milestone
Falcon
Development

Successfully merging this pull request may close these issues.
3 participants
@rasswanth-s @kamathhrishi @gmuraru