Falcon : Select Shares #273
Conversation
|
|
||
| tensor_type = get_type_from_ring(session.ring_size) | ||
| mask = (b + c).reconstruct(decode=False).type(tensor_type) | ||
|
|
There was a problem hiding this comment.
Also, I think it would be good to still do since the mask is a publlc value.
if mask=1:
d = (1-c)
elif mask=0:
d = c
else:
raise ValueError("..")
It's computationally lesser expensive since we are using public operation. Doing it mathematically involves private operations making it expensive. Select shares is used in several operations such it would be good to get as much compute efficiency as possible.
There was a problem hiding this comment.
Good question, Hrishi, we have to do it different for our tensor setting, the paper method won't work, I initially implemented what you suggested, what we want really want is ,given mpctensor x and y , we want a mix of values(some from x and some from y) ,depending on the selector bit tensor.
| raise ValueError( | ||
| f"Invalid {ring_size} for selector bit,must be of ring size 2" | ||
| ) | ||
| if shape is None: |
There was a problem hiding this comment.
Q: Do we ever get here? Since every MPCTensor should have a shape
There was a problem hiding this comment.
I thought of a scenario, when we initialize MPCTensor, with shares (actual tensor values not pointers) ,I thought to sanity check for shape.In the long run , we would have to include a sanity checks in MPCTensor which automatically infers shape from the shares.
There was a problem hiding this comment.
Binary sharing we use it only internally only with pointers, I thought of scenario, where we might mix the ring_size and give input as shares values , as pointer shares has a sanity check for shape.
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| sycret | |||
| syft @ git+https://github.com/OpenMined/PySyft@dev#egg=syft&subdirectory=packages/syft | |||
| syft @ git+https://github.com/OpenMined/PySyft@bb093294e98aa2be81412318fe8314cf6205c86b#egg=syft&subdirectory=packages/syft | |||
There was a problem hiding this comment.
Q: Can't we put dev? (or dev i still not working)
There was a problem hiding this comment.
I think it is fixed , I will revert back 👍
Description
Implementation of select shares functionality of Falcon, which takes input two tensors and outputs a tensor based on the selector bit b. Partially solves #147
How has this been tested?
Added Tests for the same.
Checklist