Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OMEdit generates invalid displayUnit modifiers for arrays of parameters #5395

Closed
OpenModelica-TracImporter opened this issue Jun 27, 2020 · 5 comments
Closed

OMEdit generates invalid displayUnit modifiers for arrays of parameters #5395

OpenModelica-TracImporter opened this issue Jun 27, 2020 · 5 comments
Assignees
@adeas31
Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature COMP/GUI/OMEdit Issue and pull request related to OMEdit
Milestone
1.22.1

Comments

@OpenModelica-TracImporter
Copy link
Member

No description provided.

@casella casella added COMP/GUI/OMEdit Issue and pull request related to OMEdit COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature labels May 16, 2023
@casella casella added this to the 1.22.0 milestone May 16, 2023
@casella
Copy link
Contributor

casella commented May 16, 2023

Load the attached model in OMEdit, double-click on m and change the display unit to kg/m3. A displayUnit modifier without each is added to the modifications, making the model invalid.

TestEachDisplayUnit.mo.txt

This was referenced May 16, 2023
Closed
Closed
@casella casella modified the milestones: 1.22.0, 1.22.1 Oct 10, 2023
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Nov 2, 2023
@adeas31
Added a context menu to allow setting final and each modifiers
d704c78 
Fixes OpenModelica#5395, Fixes OpenModelica#5405, Fixes OpenModelica#5489, Fixes OpenModelica#5737, Fixes OpenModelica#7750 and Fixes OpenModelica#10226

Apply the modifiers with one call of `setElementModifierValue`.
Added a new button for final and each context menu.
Improved the handling of modifiers.
@adeas31 adeas31 mentioned this issue Nov 2, 2023
Merged
3 tasks
@adeas31 adeas31 closed this as completed in 0281e54 Nov 2, 2023
@casella
Copy link
Contributor

casella commented Nov 2, 2023

@adeas31 would you mind porting this to the maintenance/v1.22 branch, so we can have it in 1.22.1 as planned?

@casella casella reopened this Nov 2, 2023
@casella
Copy link
Contributor

casella commented Nov 2, 2023

I'm not reopening #5405, #5489, #5737, #7750 and #10226, since I understand the commits required are the same. I would just keep this ticket as a reminder that we still need to port 0281e54 to the maintenance/v1.22 branch.

@adeas31
Copy link
Member

adeas31 commented Nov 2, 2023

There is still an issue when trying to set final and each for replaceable. I will fix it first and then port the changes.

@casella casella mentioned this issue Nov 8, 2023
Closed
adeas31 added a commit to adeas31/OpenModelica that referenced this issue Nov 14, 2023
@adeas31
Added a context menu to allow setting final and each modifiers (OpenM…
92d0526 
…odelica#11019)

Fixes OpenModelica#5395, Fixes OpenModelica#5405, Fixes OpenModelica#5489, Fixes OpenModelica#5737, Fixes OpenModelica#7750 and Fixes OpenModelica#10226

Apply the modifiers with one call of `setElementModifierValue`.
Added a new button for final and each context menu.
Improved the handling of modifiers.
adeas31 added a commit that referenced this issue Nov 14, 2023
@adeas31
Added a context menu to allow setting final and each modifiers (#11019)
bc5cc0b 
Fixes #5395, Fixes #5405, Fixes #5489, Fixes #5737, Fixes #7750 and Fixes #10226

Apply the modifiers with one call of `setElementModifierValue`.
Added a new button for final and each context menu.
Improved the handling of modifiers.
@adeas31
Copy link
Member

adeas31 commented Nov 14, 2023

Ported via PR #11571 and #11573.

@adeas31 adeas31 closed this as completed Nov 14, 2023
@casella casella mentioned this issue Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeas31 adeas31

Labels
COMP/GUI/InstBased Interface Issues with new instantiation-based OMEdit feature COMP/GUI/OMEdit Issue and pull request related to OMEdit
Projects
None yet
Milestone
1.22.1
Development

No branches or pull requests
3 participants
@adeas31 @casella @OpenModelica-TracImporter