Added a context menu to allow setting final and each modifiers

[adeas31]

Related Issues

#5395, #5405, #5489, #5737, #7750 and #10226

Purpose

Allow setting final and each modifiers.

Approach

Added a context menu next to parameter fields with final and each options.

Things todo,

• Update the code to set the modifiers of the element with single call to setElementModifierValue. Right now we call setElementModifierValue for each modifier.
• Show each option only if the parameter is an array.
• Add the same functionality for sub modifiers as well.

[casella]

@adeas31 it would be really nice to get this into 1.22.0. Do you think you can make it?

Also, it would be really nice if we could prevent people from incorrectly setting scalar values for array modifiers. This could mean:

• adding the dimension of the parameter to its name in the parameter dialog, e.g. w0[3] instead of w0 for the initial value of the angular speed in multibody systems
• refusing to accept a scalar value for arrays, with and error message popping up such as "This is an array parameter. Either provide an array of values of the same dimension or set 'each' if you want to provide a single scalar value to all the elements of the array"

[adeas31]

@adeas31 it would be really nice to get this into 1.22.0. Do you think you can make it?

1.22 might not be possible but I will try. I started working on it but then got some other work to finish. I will continue on this asap.

[casella]

Maybe we should prioritize the really quick fixes. I opened a project for Release 1.22.0 with some collected issues, maybe you can have a look at them. We could branch off 1.22.0 maintenance next week, and then cherry pick the fixes for a couple more weeks or so.

[CLAassistant]

All committers have signed the CLA.

[adeas31]

@adeas31 it would be really nice to get this into 1.22.0. Do you think you can make it?

A lot of changes are done so I recommend not to add this to 1.22.0. We should test this stuff thoroughly.

Also, it would be really nice if we could prevent people from incorrectly setting scalar values for array modifiers. This could mean:

• adding the dimension of the parameter to its name in the parameter dialog, e.g. w0[3] instead of w0 for the initial value of the angular speed in multibody systems
• refusing to accept a scalar value for arrays, with and error message popping up such as "This is an array parameter. Either provide an array of values of the same dimension or set 'each' if you want to provide a single scalar value to all the elements of the array"

Please make a separate tickets about it.

[casella]

Great! 😃

[casella]

@adeas31 it would be really nice to get this into 1.22.0. Do you think you can make it?

A lot of changes are done so I recommend not to add this to 1.22.0. We should test this stuff thoroughly.

I agree, but we should have it in 1.22.1, see #5395. Then we can make a beta and test it thoroughly.

Also, it would be really nice if we could prevent people from incorrectly setting scalar values for array modifiers. This could mean:

• adding the dimension of the parameter to its name in the parameter dialog, e.g. w0[3] instead of w0 for the initial value of the angular speed in multibody systems
• refusing to accept a scalar value for arrays, with and error message popping up such as "This is an array parameter. Either provide an array of values of the same dimension or set 'each' if you want to provide a single scalar value to all the elements of the array"

Please make a separate tickets about it.

Will do