Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype of image registration support for Kinect driver. #4

Merged

Conversation

tomoto
Copy link
Collaborator

@tomoto tomoto commented Dec 31, 2012

Hi OpenNI folks,

I created a prototype of depth-to-color image registration for Kinect driver as well as a few code readability improvement. I hope this prototype could be helpful for the early support of this feature.

I had some applications that needed this feature, but I came to know OpenNI2 did not support it yet from the community forum (http://community.openni.org/openni/topics/how_can_i_align_with_kinect). I thought I could contribute by creating a prototype since I already achieved Kinect SDK - OpenNI 1 mapping including this feature in my previous work (http://code.google.com/p/kinect-mssdk-openni-bridge/). I just applied the same idea in this prototype.

I wrote this code based on my best guess about the necessary background including the design philosophy, the intended spec, the coding convention, etc., so it might be wrong or inconsistent. Please feel free to review and fix it. If you want me to fix it, I would be happy to do my best.

Thank you very much,
Tomoto

@tomoto
Copy link
Collaborator Author

tomoto commented Jan 4, 2013

Hi All,

I apologize if I confused you by committing after making the pull request. I am finding problems with a help of community members and trying to fix them. I believe I can soon make this prototype be the most helpful status.

Thanks,
Tomoto

@tomoto
Copy link
Collaborator Author

tomoto commented Jan 5, 2013

I think the work is almost done. I will validate it with the community members...

@tomoto
Copy link
Collaborator Author

tomoto commented Jan 5, 2013

I think I am done now!

  • Problems fixed
  • Quality of the mapped depth image improved
  • Performance improved after tying different implementations and preliminary benchmarking
  • Code readability at a good level

I believe there are many people waiting for this feature, and hope this prototype helps to make them happy. Please revert back to me if you have any questions.

Thanks,
Tomoto

eddiecohen added a commit that referenced this pull request May 8, 2013
…Thanks, tomoto!)

See #4 for details.

Conflicts:
	Source/Drivers/Kinect/DepthKinectStream.cpp
@eddiecohen eddiecohen merged commit 1bec02c into OpenNI:develop May 8, 2013
@tomoto
Copy link
Collaborator Author

tomoto commented May 9, 2013

Thanks, Eddie! Hope this helps the community.

KHeresy pushed a commit to KHeresy/OpenNI2 that referenced this pull request May 30, 2014
Added check for MSVS2013 as GetVersionEx is marked as depricated.
SebasRatz pushed a commit to SebasRatz/OpenNI2 that referenced this pull request Aug 29, 2018
Added the ability to resolve device ids like "OpenNI#1" to actual device URIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants