Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALEC-244: Fix for ALEC to work when multiple UI plugins are installed #84

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

synqotik
Copy link
Contributor

@synqotik synqotik commented Nov 17, 2022

Currently in Horizon 30/31.0, ALEC and other plugins will only work if it is the only UI plugin currently installed.

Horizon 31.x is being updated to allow multiple installed plugins to work. However, this requires some changes to ALEC and other plugins.

Note that the new Horizon changes include code to check for 'legacy' plugin pattern to retain backward compatibility.

  • extensionId should be unique per plugin and set in blueprint.xml as well as used elsewhere

  • OpenNMS/Horizon is being updated to dynamically create parent Vue routes per plugin. Plugins should add their own routes as children under this route in order to work correctly. Code has been added so that new ALEC code should still work with old/existing OpenNMS code

Note: These new changes should work with existing Horizon 31.0 as well as upcoming Horizon update which includes the changes below.

See OpenNMS PR: OpenNMS/opennms#5515

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anyarybalova anyarybalova merged commit a313657 into develop Nov 17, 2022
@anyarybalova anyarybalova deleted the feature/ALEC-244-plus-route-fixes branch November 17, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants