Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-13132: derive aggregations for hosts and applications from the aggregation for conversations #24

Merged
merged 3 commits into from
May 26, 2021

Conversation

swachter
Copy link
Contributor

Issue: https://issues.opennms.org/browse/NMS-13132

  • Calculates aggregations for hosts/applications on-top of the aggregations for conversations
  • The Aggregation class now can track two host names (in case of conversation it tracks the src and dst hostname)
  • Key creation logic is simplified by decoupling it from src/dst hostname logic. Now, only a single key is returned for a document (previously key creation could return two WithHostname instances capturing the src and dst hostnames). Src/dst hostnames are now considered when the keys of conversation aggregations are mapped into two host keys for the two hosts taking part in that conversation.

@swachter swachter requested a review from fooker May 17, 2021 10:41
@swachter swachter requested a review from fooker May 25, 2021 15:36
@swachter swachter merged commit 1092cb3 into master May 26, 2021
@swachter swachter deleted the jira/nms-13132 branch May 26, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants