no-jira: rate limiter now takes part in checkpoint #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fooker
approved these changes
Aug 4, 2021
Comment on lines
49
to
51
| public static State of(long currentTimeMillis, long flowsPerSecond) { | ||
| return new State(currentTimeMillis, flowsPerSecond); | ||
| } |
There was a problem hiding this comment.
What's the reason for these methods? They just copy the exact same parameters.
There was a problem hiding this comment.
No specific reason. Just a matter of style.
There was a problem hiding this comment.
Then we should not do it. It just increases brain load...
testing/src/test/java/org/opennms/nephron/testing/flowgen/LimiterTest.java
Outdated
Show resolved
Hide resolved
swachter
force-pushed
the
swachter/benchmark-fixup
branch
from
0a2b20f
to
89c0493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running benchmarks with the direct runner checkpoints of the input are taken at regular intervals. The rate limiter state must also be part of that checkpoint in order to guarantee its rate-limiting behavior even in case of checkpoints.