Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: register NephronOptions and documentation tweaks #49

Merged
merged 7 commits into from
Feb 11, 2022

Conversation

swachter
Copy link
Contributor

This PR

  • registers the NephronOptions with the PipelineOptionsFactory; this allows to output their documentation by the command line argument --help=NephronOptions
  • includes some documentation tweaks

Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @swachter . This looks great.

docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/configuration/pages/persistence.adoc Outdated Show resolved Hide resolved
docs/modules/configuration/pages/requirements.adoc Outdated Show resolved Hide resolved
docs/modules/configuration/pages/requirements.adoc Outdated Show resolved Hide resolved
swachter and others added 5 commits February 11, 2022 13:37
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Bonrob2
Bonrob2 previously approved these changes Feb 11, 2022
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/modules/configuration/pages/persistence.adoc Outdated Show resolved Hide resolved
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swachter swachter merged commit 52f9b24 into master Feb 11, 2022
@swachter swachter deleted the sw/doc-review branch February 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants