Skip to content

Commit

Permalink
Merge branch 'master' into features/TS
Browse files Browse the repository at this point in the history
  • Loading branch information
rssntn67 committed Nov 13, 2013
2 parents e2103f4 + e86cbb7 commit c315fdb
Show file tree
Hide file tree
Showing 320 changed files with 27,899 additions and 9,134 deletions.
Expand Up @@ -64,7 +64,17 @@ org.osgi.framework.system.packages.extra=org.apache.karaf.branding,\
org.apache.commons.collections.list;version=${commonsCollectionsVersion},\
org.apache.commons.collections.map;version=${commonsCollectionsVersion},\
org.apache.commons.collections.set;version=${commonsCollectionsVersion},\
org.apache.commons.io;version=${commonsIoVersion},\
org.apache.commons.io;version="1.4.9999",\
org.apache.commons.io.comparator;version="1.4.9999",\
org.apache.commons.io.filefilter;version="1.4.9999",\
org.apache.commons.io.input;version="1.4.9999",\
org.apache.commons.io.output;version="1.4.9999",\
org.apache.commons.io;version="2.4",\
org.apache.commons.io.comparator;version="2.4",\
org.apache.commons.io.filefilter;version="2.4",\
org.apache.commons.io.input;version="2.4",\
org.apache.commons.io.output;version="2.4",\
org.apache.commons.io.monitor;version="2.4",\
org.apache.commons.lang;version=${commonsLangVersion},\
org.apache.commons.lang.builder;version=${commonsLangVersion},\
org.apache.commons.lang.enum;version=${commonsLangVersion},\
Expand Down
9 changes: 9 additions & 0 deletions core/db/pom.xml
Expand Up @@ -66,6 +66,11 @@
</plugins>
</build>
<dependencies>
<dependency>
<groupId>org.opennms.dependencies</groupId>
<artifactId>atomikos-dependencies</artifactId>
<type>pom</type>
</dependency>
<dependency>
<groupId>org.opennms.dependencies</groupId>
<artifactId>castor-dependencies</artifactId>
Expand All @@ -75,6 +80,10 @@
<groupId>org.opennms.core</groupId>
<artifactId>org.opennms.core.xml</artifactId>
</dependency>
<dependency>
<groupId>org.opennms</groupId>
<artifactId>opennms-test</artifactId>
</dependency>
<dependency>
<groupId>org.opennms</groupId>
<artifactId>opennms-util</artifactId>
Expand Down
@@ -0,0 +1,102 @@
/*******************************************************************************
* This file is part of OpenNMS(R).
*
* Copyright (C) 2012 The OpenNMS Group, Inc.
* OpenNMS(R) is Copyright (C) 1999-2012 The OpenNMS Group, Inc.
*
* OpenNMS(R) is a registered trademark of The OpenNMS Group, Inc.
*
* OpenNMS(R) is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published
* by the Free Software Foundation, either version 3 of the License,
* or (at your option) any later version.
*
* OpenNMS(R) is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with OpenNMS(R). If not, see:
* http://www.gnu.org/licenses/
*
* For more information contact:
* OpenNMS(R) Licensing <license@opennms.org>
* http://www.opennms.org/
* http://www.opennms.com/
*******************************************************************************/

package org.opennms.core.db;

import java.sql.SQLException;
import java.sql.SQLFeatureNotSupportedException;
import java.util.logging.Logger;

import org.opennms.netmgt.config.opennmsDataSources.JdbcDataSource;

import com.atomikos.jdbc.AtomikosDataSourceBean;


/**
<bean id="dataSource" class="com.atomikos.jdbc.AtomikosDataSourceBean" destroy-method="close">
<property name="uniqueResourceName" value="opennms"/>
<property name="xaDataSource">
<bean class="org.opennms.core.db.XADataSourceFactoryBean" />
</property>
<property name="poolSize" value="30"/>
<!-- This test query assures that connections are refreshed following a database restart -->
<property name="testQuery" value="SELECT 1"/>
</bean>
*/

public class AtomikosDataSourceFactory extends AtomikosDataSourceBean implements ClosableDataSource {

private static final long serialVersionUID = -6411281260947841402L;

public AtomikosDataSourceFactory(JdbcDataSource ds) {
this();
}

public AtomikosDataSourceFactory() {
super.setUniqueResourceName("opennms");
super.setXaDataSource(XADataSourceFactory.getInstance());
super.setPoolSize(30);
super.setTestQuery("SELECT 1");
}

// Uncomment when we require Java 7
//@Override
public Logger getParentLogger() throws SQLFeatureNotSupportedException {
throw new SQLFeatureNotSupportedException();
}

@Override
public <T> T unwrap(Class<T> iface) throws SQLException {
throw new SQLException();
}

@Override
public boolean isWrapperFor(Class<?> iface) throws SQLException {
return false;
}

@Override
public void setIdleTimeout(int idleTimeout) {
super.setMaxIdleTime(idleTimeout);
}

@Override
public void setMinPool(int minPool) {
super.setMinPoolSize(minPool);
}

@Override
public void setMaxPool(int maxPool) {
super.setMaxPoolSize(maxPool);
}

@Override
public void setMaxSize(int maxSize) {
super.setMaxPoolSize(maxSize);
}
}
Expand Up @@ -29,14 +29,11 @@
package org.opennms.core.db;

import java.beans.PropertyVetoException;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.sql.SQLException;

import javax.sql.DataSource;

import org.apache.commons.io.IOUtils;
import org.exolab.castor.xml.MarshalException;
import org.exolab.castor.xml.ValidationException;
import org.opennms.netmgt.config.opennmsDataSources.JdbcDataSource;
Expand All @@ -57,37 +54,10 @@ public abstract class BaseConnectionFactory implements ClosableDataSource {
* @throws java.beans.PropertyVetoException if any.
* @throws java.sql.SQLException if any.
*/
protected BaseConnectionFactory(final InputStream stream, final String dsName) throws MarshalException, ValidationException, PropertyVetoException, SQLException {
LOG.info("Setting up data source {} from input stream.", dsName);
final JdbcDataSource ds = ConnectionFactoryUtil.marshalDataSourceFromConfig(stream, dsName);
protected BaseConnectionFactory(final JdbcDataSource ds) throws MarshalException, ValidationException, PropertyVetoException, SQLException {
initializePool(ds);
}

/**
* @param configFile A configuration file name.
* @param dsName The data source's name.
* @throws java.io.IOException if any.
* @throws org.exolab.castor.xml.MarshalException if any.
* @throws org.exolab.castor.xml.ValidationException if any.
* @throws java.beans.PropertyVetoException if any.
* @throws java.sql.SQLException if any.
*/
protected BaseConnectionFactory(final String configFile, final String dsName) throws IOException, MarshalException, ValidationException, PropertyVetoException, SQLException {
/*
* Set the system identifier for the source of the input stream.
* This is necessary so that any location information can
* positively identify the source of the error.
*/
final FileInputStream fileInputStream = new FileInputStream(configFile);
LOG.info("Setting up data sources from {}.", configFile);
try {
final JdbcDataSource ds = ConnectionFactoryUtil.marshalDataSourceFromConfig(fileInputStream, dsName);
initializePool(ds);
} finally {
IOUtils.closeQuietly(fileInputStream);
}
}

protected abstract void initializePool(final JdbcDataSource ds) throws SQLException;

/**
Expand Down Expand Up @@ -140,7 +110,7 @@ protected BaseConnectionFactory(final String configFile, final String dsName) th
* @throws java.sql.SQLException if any.
*/
@Override
public void close() throws SQLException {
public void close() {
}

/**
Expand Down
177 changes: 0 additions & 177 deletions core/db/src/main/java/org/opennms/core/db/C3P0ConnectionFactory.java

This file was deleted.

0 comments on commit c315fdb

Please sign in to comment.