Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HZN-956: Implement browser notification #2284

Merged
merged 12 commits into from Feb 6, 2019
Merged

HZN-956: Implement browser notification #2284

merged 12 commits into from Feb 6, 2019

Conversation

fooker
Copy link
Member

@fooker fooker commented Dec 8, 2018

@fooker
Copy link
Member Author

fooker commented Dec 8, 2018

@fooker fooker closed this Dec 8, 2018
@fooker fooker reopened this Dec 8, 2018
@indigo423
Copy link
Member

indigo423 commented Dec 8, 2018

@indigo423 suggested to use a more modern/flat logo instead of https://github.com/OpenNMS/opennms/blob/5f4ae13ccef1ff185c49595e41ca15449283b6fb/opennms-webapp/src/main/webapp/images/o-192.png. Thoughts?

Updated so it uses the new o-logo

@fooker
Copy link
Member Author

fooker commented Dec 12, 2018

Mentioned in whatsnew

@indigo423
Copy link
Member

I did a functional test and got it to work with Safari, Chrome and Firefox. 👍 from me.

@pbrane
Copy link

pbrane commented Dec 15, 2018

I tested as well. Works for me w/Safari. How difficult would it be to make the notification a clickable reference back to the notification in the browser such that the user could ack the notification?

@pbrane
Copy link

pbrane commented Dec 15, 2018

Pretty cool!
image

@indigo423
Copy link
Member

indigo423 commented Dec 16, 2018

I tested as well. Works for me w/Safari. How difficult would it be to make the notification a clickable reference back to the notification in the browser such that the user could ack the notification?

I tried this but but they get encoded and are not interpreted as HTML links. I can imagine the base href can be unknown to opennms itself e.g. behind proxy and the opennms jetty property opennms.web.base-url = https://%x%c/

@pbrane
Copy link

pbrane commented Dec 16, 2018

Bummer.

@fooker
Copy link
Member Author

fooker commented Dec 18, 2018

How difficult would it be to make the notification a clickable reference back to the notification in the browser such that the user could ack the notification?

I've already looked into it. There is some support for "actions". But it's still beta and not supported by most stable browsers. It also requires HTTPS and a lot of changes to the authentication handling. Maybe later...

@j-white
Copy link
Contributor

j-white commented Jan 17, 2019

Awesome. Thanks.

@indigo423
Copy link
Member

indigo423 commented Jan 17, 2019

@fooker what means your commit message:

HZN-956: Migrated js to asserts

😄

@j-white j-white merged commit cbbe6a4 into develop Feb 6, 2019
@j-white j-white deleted the jira/HZN-956 branch February 6, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants