New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HZN-956: Implement browser notification #2284
Conversation
fooker
commented
Dec 8, 2018
- JIRA: http://issues.opennms.org/browse/HZN-956
@indigo423 suggested to use a more modern/flat logo instead of https://github.com/OpenNMS/opennms/blob/5f4ae13ccef1ff185c49595e41ca15449283b6fb/opennms-webapp/src/main/webapp/images/o-192.png. Thoughts? |
Updated so it uses the new o-logo |
opennms-webapp/src/main/java/org/opennms/web/notification/NotificationStreamServlet.java
Outdated
Show resolved
Hide resolved
Mentioned in whatsnew |
I did a functional test and got it to work with Safari, Chrome and Firefox. 👍 from me. |
I tested as well. Works for me w/Safari. How difficult would it be to make the notification a clickable reference back to the notification in the browser such that the user could ack the notification? |
I tried this but but they get encoded and are not interpreted as HTML links. I can imagine the base href can be unknown to opennms itself e.g. behind proxy and the opennms jetty property |
Bummer. |
I've already looked into it. There is some support for "actions". But it's still beta and not supported by most stable browsers. It also requires HTTPS and a lot of changes to the authentication handling. Maybe later... |
opennms-doc/guide-admin/src/asciidoc/text/notifications/introduction.adoc
Outdated
Show resolved
Hide resolved
Awesome. Thanks. |
@fooker what means your commit message:
😄 |