using correct variable data types instead of using generic Object type #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerRick
added a commit
that referenced
this pull request
Apr 25, 2013
using correct variable data types instead of using generic Object type
|
Actually, since this code is compiled to javascript to GWT, I'm not confident this patch reliably solves the problem, and will additionally be very difficult to test (since testing in Eclipse isn't enough to know it's working). Since we're trying to go to a release candidate for 1.12 right now, I've gone ahead and reverted it. |
|
We have merged the changes with master branch as 1.12 branch is very close to the release. |
indigo423
added a commit
that referenced
this pull request
Jan 24, 2015
Fixed and enhanced - I have merged this pull request make sense
indigo423
pushed a commit
that referenced
this pull request
Jul 6, 2015
NMS-5272: Removed unnecessary spaces and formatted file.
j-white
pushed a commit
that referenced
this pull request
Dec 10, 2015
7 tasks
8 tasks
deejgregor
pushed a commit
that referenced
this pull request
Oct 10, 2022
We published an image for ALEC in Docker Hub, so the Chart is fully functional. GitHub won't be used anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using correct data type for the variables instead of using generic Object type and down casting it to appropriate type.
ternary operator is used where ever possible as a replacement to the if condition to made the code look concise.