Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Sample Vocabulary for Language Model #318

Merged
merged 7 commits into from
Jun 28, 2017

Conversation

jsenellart
Copy link
Contributor

deprecated option -sample_tgt_vocab which is now replaced by -sample_vocab and applies on language models too.

@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #318 into master will decrease coverage by 0.04%.
The diff coverage is 70.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   70.78%   70.73%   -0.05%     
==========================================
  Files          68       68              
  Lines        5637     5663      +26     
==========================================
+ Hits         3990     4006      +16     
- Misses       1647     1657      +10
Impacted Files Coverage Δ
onmt/translate/Translator.lua 26.92% <0%> (ø) ⬆️
onmt/train/Trainer.lua 22.61% <0%> (-0.19%) ⬇️
onmt/modules/Generator.lua 80.85% <100%> (ø) ⬆️
onmt/Seq2Seq.lua 61.48% <28.57%> (ø) ⬆️
onmt/LanguageModel.lua 81.66% <37.5%> (-3.16%) ⬇️
onmt/data/SampledDataset.lua 72.33% <89.47%> (-0.06%) ⬇️
onmt/utils/ExtendedCmdLine.lua 66.2% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15dae77...6496be4. Read the comment docs.

@guillaumekln guillaumekln merged commit d7b1768 into OpenNMT:master Jun 28, 2017
natsegal pushed a commit to natsegal/OpenNMT that referenced this pull request Jul 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants