Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Broken with Sphinx 2+: Logging API #29

Closed
miili opened this issue Dec 20, 2018 · 0 comments · Fixed by #31
Closed

Plugin Broken with Sphinx 2+: Logging API #29

miili opened this issue Dec 20, 2018 · 0 comments · Fixed by #31

Comments

@miili
Copy link

miili commented Dec 20, 2018 •
edited

Hi there,

thanks for maintaining this useful plugin!

In Sphinx 2+ Sphinx object has no logging interface and

app.warn('Unexpected return code {0} from command {1}'.format(
         returncode, command))

in https://github.com/NextThought/sphinxcontrib-programoutput/blob/master/src/sphinxcontrib/programoutput/__init__.py#L223 fails.

The new approach is documented here https://www.sphinx-doc.org/en/master/extdev/logging.html

Best, M
@miili miili mentioned this issue Dec 20, 2018
Closed
jamadden added a commit that referenced this issue Dec 22, 2018
@jamadden
Fix tests with Sphinx >1.8 and resolve warnings
098d2e6 
Fixes #29 and fixes #30

This requires dropping support for Sphinx < 1.7.

Add support for Python 3.7.
@jamadden jamadden mentioned this issue Dec 22, 2018
Merged
clrpackages pushed a commit to clearlinux-pkgs/sphinxcontrib-programoutput that referenced this issue Dec 26, 2018
@fenrus75
[update to 0.13] Fix pylint on Python 3
74f7ffb 
Edward Betts (1):
      correct spelling mistake

Jason Madden (4):
      Back to development: 0.12
      Fix tests with Sphinx >1.8 and resolve warnings
      Fix pylint on Python 3
      Preparing release 0.13

0.13 (2018-12-22)
=================

- Drop support for Sphinx < 1.7.

- Fix tests on Sphinx >= 1.8.0.

- Restore error message into the document by default from failed
  program runs on Sphinx >= 1.8.0b1.

- Fix deprecation warnings on Sphinx >= 1.8. Reported in `issue 29
  <https://github.com/NextThought/sphinxcontrib-programoutput/issues/29>`_
  by miili.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests with sphinx >= 1.8 and resolve warnings OpenNTI/sphinxcontrib-programoutput
1 participant
@miili