Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging with Sphinx 2+ #30

Closed
wants to merge 1 commit into from
Closed

fix logging with Sphinx 2+ #30

wants to merge 1 commit into from

Conversation

miili
Copy link

@miili miili commented Dec 20, 2018 •
edited

Fixes logging compat in Sphinx 2+, see #29.

jamadden added a commit that referenced this pull request Dec 22, 2018
@jamadden
Fix tests with Sphinx >1.8 and resolve warnings
098d2e6 
Fixes #29 and fixes #30

This requires dropping support for Sphinx < 1.7.

Add support for Python 3.7.
@jamadden jamadden mentioned this pull request Dec 22, 2018
Merged
@jamadden
Copy link
Member

jamadden commented Dec 22, 2018 •
edited

Thanks for reporting this, and thanks for offering the fix! There were other broken tests that needed to be tracked down, so we have #31 that resolves it all.

0.14 has been pushed to PyPI.

@jamadden jamadden closed this in #31 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miili @jamadden