Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when clicking CLOSE on POSITIONING window, OOM closes with error #1494

Closed
valdisj opened this issue Jan 12, 2020 · 1 comment · Fixed by #1495
Closed

when clicking CLOSE on POSITIONING window, OOM closes with error #1494

valdisj opened this issue Jan 12, 2020 · 1 comment · Fixed by #1495
Assignees
@dg0yt
Labels
crash

Comments

@valdisj
Copy link

valdisj commented Jan 12, 2020

Running OOM on Mac OS 10.15.2 (19C57) Catalina

Steps to reproduce

  1. Open Map
  2. Open Templates
    3.Click on Template and Choose "EDIT" => Positioning
  3. Do or not do any edits in numers in Positioning window
  4. Click "CLOSE" button in positioning window

Actual behaviour

All OOM exits with error

Expected behaviour

Window should just close

Configuration

Mapper Version: 0.9.1
Operating System: Mac OS 10.15.2 (19C57) Catalina
@dg0yt dg0yt added the crash label Jan 12, 2020
@dg0yt
Copy link
Member

dg0yt commented Jan 12, 2020

Confirmed on macOS.

@dg0yt dg0yt self-assigned this Jan 12, 2020
dg0yt added a commit that referenced this issue Jan 13, 2020
@dg0yt
MapEditorController: Defer template position dock deletion
76f08d5 
We must not immediately delete a TemplatePositionDockWidget when we
remove it from the list: When the removal is triggered from a close
event, there might be accesses following our event handling.
Fixes GH-1494 (crash on closing dock widget).
@dg0yt dg0yt mentioned this issue Jan 13, 2020
Merged
dg0yt added a commit that referenced this issue Jan 14, 2020
@dg0yt
MapEditorController: Defer template position dock deletion
b4466b0 
We must not immediately delete a TemplatePositionDockWidget when we
remove it from the list: When the removal is triggered from a close
event, there might be accesses following our event handling.
Fixes GH-1494 (crash on closing dock widget).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dg0yt dg0yt

Labels
crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MapEditorController: Defer template position dock deletion OpenOrienteering/mapper
2 participants
@valdisj @dg0yt