Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISSprOM 2019 symbol set #1348

Merged
merged 10 commits into from
Dec 11, 2019
Merged

Add ISSprOM 2019 symbol set #1348

merged 10 commits into from
Dec 11, 2019

Conversation

dg0yt
Copy link
Member

@dg0yt dg0yt commented Sep 10, 2019

Task: GH-1037

@dg0yt dg0yt changed the base branch from dev to master September 17, 2019 04:58
@dg0yt
Copy link
Member Author

dg0yt commented Dec 7, 2019

Let's move on with ISSprOM.

TODO: Scaling/deployment.

Request for comment: Color levels. Most significant deviations:

  • Grey for bare rock is above green for area features, as in
    our ISOM 2017-2 symbol set.
  • Blue 100% for area features and blue screens are below light
    browns.

@dg0yt dg0yt added this to the v0.9.2 milestone Dec 7, 2019
Taking into account:
- our ISOM 2017-2 symbol set
- IOF's ISOM 2017 Appendix 1, version 3, 2019-11-08.

Most significant deviations:
- Grey for bare rock is above green for area features, as in
  our ISOM 2017-2 symbol set.
- Blue 100% for area features and blue screens are below light
  browns.

Change default view mode to non-overprinting.
@dg0yt dg0yt force-pushed the ISSprOM-2019 branch 2 times, most recently from 92e7d74 to beaca95 Compare December 8, 2019 09:22
Revise descriptions.
Add area symbols for broken ground, boulder field, stony ground.
Adjust symbol numbers.
... taking into account map conversions from ISSOM and ISOM 2017-2.
@dg0yt dg0yt changed the title WIP: Add ISSprOM 2019 symbol set Add ISSprOM 2019 symbol set Dec 8, 2019
@dg0yt
Copy link
Member Author

dg0yt commented Dec 9, 2019

@yevhenmazur @krticka @Zerbembasqwibo @ollesmaps I'm going to merge this soon, for the next master build.
ISSprOM.zip

@ollesmaps
Copy link

ollesmaps commented Dec 9, 2019

I would rather put grey for bare rock bellow greens. Bare rock is in character similar to other open areas (yellows). And bushes (green) grow on top of it.
This discussion somehow relates:
https://www.facebook.com/groups/485564718218028/permalink/2432700646837749/

Blue area x light browns. Order really does not matter IMHO.

@ollesmaps
Copy link

Offtopic?
"In laser printing overprinting effect must be simulated. The easiest way to do this is to place the purple track colour in the colour order below black, brown and blue 100% colours."
How is this going to be achived in stand alone apps (Purple Pen with Mapper as template)?

@ollesmaps
Copy link

I do not like contours above edges of pavement. I think thin linear pavements almost disappear bellow contours.

I know it is either/ or situation. Either seamless connection of linear pavements or contours bellow edges of pavement. It is a pity we can not have both at the same time.

@krticka
Copy link
Contributor

krticka commented Dec 9, 2019 via email

@dg0yt
Copy link
Member Author

dg0yt commented Dec 9, 2019

I would rather put grey for bare rock bellow greens. Bare rock is in character similar to other open areas (yellows).

This is a fair point from a consistency point of view: yellow and grey meaning open area.

But there is another view on consistency: Other than yellow and green, grey means no vegetation.
Now, yellow and green are used together for some kind of vegetation (open land with scattered bushes, orchard, vineyard). Grey must not mix in. Thus if we want to make it easy to use the symbols right, and hard to use these symbols wrongly, grey can be either above green or below yellow, but not in the middle.
(Side note: I also added a level of black between yellow and green, for open sandy ground and for cultivated land: either both yellow and black are covered by green, or both are visible.)

Now assuming that bare rock is less common than yellow and green, I think it is easier to add accurate patches of grey on top of yellow and green, than anything else.

And bushes (green) grow on top of it.

There is no problem with bushes etc. anyway: This green is on a much higher level, even above paved areas, bodies of water, (lower purple) track symbols.

@dg0yt
Copy link
Member Author

dg0yt commented Dec 9, 2019

Offtopic?
"In laser printing overprinting effect must be simulated. The easiest way to do this is to place the purple track colour in the colour order below black, brown and blue 100% colours."
How is this going to be achived in stand alone apps (Purple Pen with Mapper as template)?

Haha! I was wondering how long it takes for someone to come up with this question...
Probably not so much an issue for international events. However, that's just a minor share of all orienteering activites, and I think it is reasonable to ask for a way to do proper course setting on top of fixed map content (PNG, JPG, whatever).

@dg0yt
Copy link
Member Author

dg0yt commented Dec 10, 2019

I do not like contours above edges of pavement. I think thin linear pavements almost disappear bellow contours.

Same for me. However, I feel that is unclear what is actually desired by the specification. There is no example or instruction given in ISSprOM, and also the color specs aren't a complete and consistent guide. (What about contour lines, or track symbols, and black edges of buildings and uncrossable bodies of water?)

When a paved path follows a contour, you can still move the contour away from the edge of the paved area.

@ollesmaps
Copy link

Wouldn't be there a software solution to this conondrum possible? A local overprint effect? I assume it might come in hand also in other stances.

Note: In spot colors printing this is solved.

@dg0yt
Copy link
Member Author

dg0yt commented Dec 11, 2019

Wouldn't be there a software solution to this conondrum possible? A local overprint effect? I assume it might come in hand also in other stances.

Note: In spot colors printing this is solved.

One software solution was overprinting simulation.

  • Pros: Mitigates some other issues. Output only, not affecting file format
  • Cons: Rasterization / file size. Mixed colors possibly not accurate.

Another solution would be to use the brown infill to for clipping the black edge lines when they are printed above the brown contour lines.

  • Pros: Desired output.
  • Cons: Not possible with current file formats, thus likely to lead to incompatibilities. Possibly computationally expensive a) when computing clipping masks (map software) and b) when using the clipping mask (printer driver, printer).

CMYK+B will solve this by... overprinting. However, this means to actually produce a suitable PDF file to give to the print shop. Not sure which map software can do this at the moment, without tricks.

@dg0yt
Copy link
Member Author

dg0yt commented Dec 11, 2019

I guess I can proceed with merging, to offer the symbol set with the next master snapshot, for broader review?

There is no short-term solution to the cyclic problem of 'edge covers contour covers infill covers edge' problem.

  • Current implementation: brown contours above the others. No direct contradiction to ISSprOM.
  • Alternative: black edges above the others. For now, this means forcing map makers to draw crossing explicitly in order to conform to ISSprOM.

If we would implement the missing 'line gap' feature for border lines (GH-150) it would be possible to interrupt edges at crossings. However, I think it may be tricky to hit the exact points exactly. With the current implementation, it should be possible to upgrade maps safely. With the mentioned alternative, the map data would already be different, so an upgrade would be less beneficial.

@dg0yt dg0yt merged commit f3bf5d2 into master Dec 11, 2019
@dg0yt dg0yt mentioned this pull request Mar 13, 2020
@dg0yt dg0yt deleted the ISSprOM-2019 branch July 11, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants