Revise template georeferencing setup #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type was used for a parameter which had two usages, both with the same actual value. With the parameter removed, we can simplify the constructor. This change facilitates further modifications.
|
@lpechacek I don't ask for a thorough review. I just would like to verify that the changes take a good direction, and we can let them into the pending master snapshot. |
Handle CRS and transformation options more independently. Pass available georeferencing options to the CRS selection dialog, and initialize the "current" selection accordingly. Allow overriding of CRS information when it differs from the map, or when (re-)enabling georeferencing for an existing template. Allow world files to be used even with local georeferencing (assuming same CRS). Mitigates GH-1515 (slightly misplaced templates).
Don't return the resulting value, but indicate success or error. This is necessary to suppress an error message if the user intentionally cancelled CRS configuration on enabling geoerefencing.
lpechacek
approved these changes
Feb 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase flexibility without further complicating the code. Most of all,