Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AreaBomb should set a despawn time #413

Closed
MikeJeffers opened this issue Oct 17, 2021 · 2 comments
Closed

AreaBomb should set a despawn time #413

MikeJeffers opened this issue Oct 17, 2021 · 2 comments
Assignees
@jeffmaley
Labels
bug Something isn't working Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation enhancement New feature or request good first issue Good for newcomers Priority: High This ticket needs to be completed asap
Projects
Game Server

Comments

@MikeJeffers
Copy link

AreaBombs should probably have some despawn timer set (to avoid spamming them and letting them sit indefinitely)
By using: https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Zones/Eggs/Egg.cs#L39
On: https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Zones/Eggs/AreaBomb.cs
Override the Initialize method like other eggs: https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Zones/PBS/PBSEgg.cs#L30-L34 or https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Zones/NpcSystem/NpcEgg.cs#L9-L13
@MikeJeffers MikeJeffers added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2021
@MikeJeffers MikeJeffers added this to BACKLOG in Game Server via automation Oct 17, 2021
jeffmaley added a commit that referenced this issue Oct 22, 2021
@jeffmaley
github issue #413 - added despawn timer for areabomb
bc19ff8
@jeffmaley jeffmaley self-assigned this Oct 22, 2021
@jeffmaley
Copy link

I add this to my PR for #400

@MikeJeffers MikeJeffers moved this from BACKLOG to Review in progress in Game Server Oct 23, 2021
@MikeJeffers MikeJeffers added Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Priority: High This ticket needs to be completed asap labels Oct 29, 2021
@MikeJeffers
Copy link
Author

Closed by @jeffmaley on #400

Game Server automation moved this from Review in progress to Done Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffmaley jeffmaley

Labels
bug Something isn't working Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation enhancement New feature or request good first issue Good for newcomers Priority: High This ticket needs to be completed asap
Projects
Game Server
Archived in project
Game Server
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeJeffers @jeffmaley