cgi-bin/admin.c: Prevent accessing ppd_name if ppd_name is NULL

The fix provided by Alfonso Gregory, fixes regression after PR #218.
OpenPrinting · Sep 8, 2021 · 92df865 · 92df865
1 parent b82b2fb
commit 92df865
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/cgi-bin/admin.c b/cgi-bin/admin.c
@@ -1218,17 +1218,7 @@ do_am_printer(http_t *http,		/* I - HTTP connection */
 
       cgiCopyTemplateLang("printer-modified.tmpl");
     }
-    else if (strcmp(ppd_name, "everywhere") && !strstr(ppd_name, "driverless"))
-    {
-      /*
-       * If we don't have an everywhere model, show printer-added
-       * template with warning about drivers going away...
-       */
-
-      cgiStartHTML(title);
-      cgiCopyTemplateLang("printer-added.tmpl");
-    }
-    else
+    else if (ppd_name && (strcmp(ppd_name, "everywhere") == 0 || strstr(ppd_name, "driverless")))
     {
      /*
       * Set the printer options...
@@ -1238,6 +1228,16 @@ do_am_printer(http_t *http,		/* I - HTTP connection */
       do_set_options(http, 0);
       return;
     }
+    else
+    {
+     /*
+      * If we don't have an everywhere model, show printer-added
+      * template with warning about drivers going away...
+      */
+
+      cgiStartHTML(title);
+      cgiCopyTemplateLang("printer-added.tmpl");
+    }
 
     cgiEndHTML();
   }