Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian: don't let CUPS remove the "(recommended)" from Foomatic PPDs #33

Closed
wants to merge 1 commit into from
Closed

Debian: don't let CUPS remove the "(recommended)" from Foomatic PPDs #33

wants to merge 1 commit into from

Conversation

OdyX
Copy link
Contributor

@OdyX OdyX commented Nov 4, 2020

No description provided.

@OdyX
CUPS removes the "(recommended)" comments of the NickNames of Foomati…
08903bf 
…c PPDs when listing available PPDs. This patch removes this removal action.
@michaelrsweet
Copy link
Member

These drivers are only "recommended" because there is no other choice. The information has no purpose, and making a recommendation like this shouldn't be encoded in the PPD file, it should be in the tools choosing the PPD file.

@michaelrsweet michaelrsweet self-assigned this Nov 4, 2020
@michaelrsweet michaelrsweet added the wontfix This will not be worked on label Nov 4, 2020
michaelrsweet
michaelrsweet requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need is code that will evaluate whether a PPD file/driver is the best one for the job. The "recommended" label in the PPD file is like a "voted best 3 years in a row" banner on a cereal box.

michaelrsweet
michaelrsweet requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments I added previously; "recommended" isn't a valid make-and-model string, what is really needed is a real way to determine which driver is the best.

@zdohnal
Copy link
Member

zdohnal commented Oct 27, 2021

Didier has left printing community for a time, closing this PR, since the solution needs to be approached differently than in this PR.

@zdohnal zdohnal closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet michaelrsweet requested changes

Assignees

@michaelrsweet michaelrsweet

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OdyX @michaelrsweet @zdohnal