scheduler/ipp.c: Convert incoming ColorModel attribute #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client uses PPD option ColorModel (which is converted into attribute to be sent via IPP) for changing the default color option (which happens via CUPS-Add-Modify-Printer operation), we have to convert ColorModel into print-color-mode attribute, so the print-color-mode-default attribute gets updated. The change survives reboot because print-color-mode is saved as an option in printer's entry in /etc/cups/printers.conf.
zdohnal
force-pushed
the
change_defaults
branch
from
0b553b7
to
c114e3c
Compare
zdohnal
requested review from
michaelrsweet
and removed request for
tillkamppeter
|
@michaelrsweet this PR and #461 should fix all regressions regarding color from 2.4.1 - would you mind reviewing them? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client uses PPD option ColorModel (which is converted into
attribute to be sent via IPP) for changing the default color option
(which happens via CUPS-Add-Modify-Printer operation), we have to
convert ColorModel into print-color-mode attribute, so the
print-color-mode-default attribute gets updated.
The change survives reboot because print-color-mode is saved as an
option in printer's entry in /etc/cups/printers.conf.