cups/dest.c: Look for default printer on network as well #455
Conversation
The current code of `cupsGetNamedDest()` doesn't look up on network for a default printer. The result is a temporary queue cannot be set as a default printer. Fixes OpenPrinting#452
zdohnal
requested review from
michaelrsweet and
tillkamppeter
and removed request for
michaelrsweet
|
@tillkamppeter I wouldn't want to disturb Mike more than it is necessary (my guess he's on vacation), would you mind reviewing the PR? |
|
For me it fully makes sense so that virtual/temporary queues can be used like physical/permanent ones, especially if the latter will not exist any more in CUPS 3.x. Also for the user experience and transparency it is important to have the same behavior. #452 is really a bug. |
|
@zdonal @tillkamppeter I am not on vacation now, but I will be in PWG meetings the next three days. |
|
@tillkamppeter OT: permanent queues will be in CUPS Sharing server module, thus libcups will have to support them as well AFAIK. Thank you for the review! @michaelrsweet I took your new avatar and 'busy' in nickname as you are out of the office and enjoying some free time, so I didn't want to disturb :) |
The current code of
cupsGetNamedDest()doesn't look up on network fora default printer. The result is a temporary queue cannot be set as a
default printer.
Fixes #452