dest.c: Call cupsEnumDests() only if data.name is not NULL (fixes #719) #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nPrinting#719) Fixes regression created by OpenPrinting#452 - in case there is no default destination and `cupsGetNamedDest()` is called to get one (by calling it with argument `name` as NULL), the function crashes. It happens because we try to look for the default printer on the network (where we access `data.name`, which is NULL, in callback), but we never found out the printer's name. Original fix by Emilio Cobos Alvarez.
|
(Once this is reviewed - I'll merge it to 2.4.x as well) |
|
I'll make sure this is mirrored in the libcups3 repo as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression created by #452 - in case there is no default
destination and
cupsGetNamedDest()is called to get one (by calling itwith argument
nameas NULL), the function crashes.It happens because we try to look for the default printer on the network
(where we access
data.name, which is NULL, in callback), but we neverfound out the printer's name.
Original fix by Emilio Cobos Alvarez.