Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String 5430 #1146

Closed
14 tasks done
spacek531 opened this issue Jul 7, 2017 · 5 comments
Closed
14 tasks done

String 5430 #1146

spacek531 opened this issue Jul 7, 2017 · 5 comments
Labels
changed field

Comments

@spacek531
Copy link
Contributor

spacek531 commented Jul 7, 2017 •
edited by Gymnasiast
Loading

New strings from PR OpenRCT2/OpenRCT2/pull/5755

Title sequence wait periods are no longer determined in seconds but now in milliseconds.

STR_5430   : Time in milliseconds

Updated in:

  • en-US
  • cs-CZ
  • nl-NL
  • fr-FR
  • de-DE
  • pt-BR
  • es-ES
  • it-IT
  • sv-SE
  • nb-NO
  • ko-KR
  • zh-CN
  • zh-TW
  • ca-ES
@octaroot
Copy link
Contributor

octaroot commented Jul 7, 2017 •
edited
Loading

I'm confused. The PR you linked is from this repository, not the main game. Also you are changing the STR_5424 string. Your PR in the main game repo is not even merged yet.

@spacek531
Copy link
Contributor Author

sorry, this is my first time.

@Nubbie
Copy link
Contributor

Nubbie commented Jul 7, 2017 •
edited
Loading

@spacek531
Note: Wrong string-id, the correct one is

STR_5430    :Milliseconds to wait:

Also change the title to String 5430, then It's good 😄

@Nubbie Nubbie mentioned this issue Jul 7, 2017
Merged
@spacek531 spacek531 changed the title Seconds -> milliseconds String 5340 Jul 7, 2017
@spacek531
Copy link
Contributor Author

haha 5424 was the string I had to change to use UINT8, sorry about that

@octaroot
Copy link
Contributor

octaroot commented Jul 8, 2017

@spacek531 Oh, I see, right!
btw the title of this PR is still wrong :D it's 5430 not 5340, but that's just me being mean :-)

octaroot added a commit to octaroot/Localisation that referenced this issue Jul 8, 2017
@octaroot
cs-CZ: Apply OpenRCT2#1146
ddbd3fc
@octaroot octaroot mentioned this issue Jul 8, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 8, 2017
@octaroot @Gymnasiast
cs-CZ: Apply #1146
5e99e46
@Gymnasiast Gymnasiast changed the title String 5340 String 5430 Jul 8, 2017
Gymnasiast added a commit that referenced this issue Jul 8, 2017
@Gymnasiast
nl-NL: Apply #1146
d425b27
@telk5093 telk5093 mentioned this issue Jul 8, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 8, 2017
@telk5093 @Gymnasiast
ko-KR: Apply #1146
a0c1a68
@LucaRed LucaRed mentioned this issue Jul 17, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 17, 2017
@LucaRed @Gymnasiast
it-IT: apply #1138 and #1146
edbe94c 
it-IT: apply #1138 and #1146
@izhangfei izhangfei mentioned this issue Jul 18, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 18, 2017
@izhangfei @Gymnasiast
zh-CN: Apply #1105 #1108 #1111 #1114 #1117 #1122 #1129 #1133 #1138 #1146
9f5d85a
@Wirlie Wirlie mentioned this issue Jul 21, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 22, 2017
@Wirlie @Gymnasiast
es-ES: Apply #1111 #1114 #1117 #1122 #1129 #1133 #1138 #1146
d2d9493
danidoedel added a commit to danidoedel/Localisation that referenced this issue Jul 22, 2017
@danidoedel
de-DE: Apply OpenRCT2#1146
31dd9e1
@danidoedel danidoedel mentioned this issue Jul 22, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 22, 2017
@danidoedel @Gymnasiast
de-DE: Apply #1146
f8842a8
@daihakken daihakken mentioned this issue Jul 23, 2017
Merged
@Gymnasiast Gymnasiast reopened this Jul 23, 2017
J0anJosep added a commit to J0anJosep/Localisation that referenced this issue Jul 24, 2017
@J0anJosep
ca-ES: Apply OpenRCT2#1086 OpenRCT2#1105 OpenRCT2#1108 OpenRCT2#1114 O…
e79845d 
…penRCT2#1117 OpenRCT2#1122 OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146 OpenRCT2#1162 OpenRCT2#1111
J0anJosep added a commit to J0anJosep/Localisation that referenced this issue Jul 24, 2017
@J0anJosep
ca-ES: Apply OpenRCT2#1086 OpenRCT2#1105 OpenRCT2#1108 OpenRCT2#1111 O…
bdf666f 
…penRCT2#1114 OpenRCT2#1117 OpenRCT2#1122 OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146 OpenRCT2#1162
@J0anJosep J0anJosep mentioned this issue Jul 24, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 24, 2017
@J0anJosep @Gymnasiast
ca-ES: Apply #1086 #1105 #1108 #1111 #1114 #1117 #1122 #1129 #1133 #1138
07e6b84 
 #1146 #1162
JoelTroch added a commit to JoelTroch/Localisation that referenced this issue Jul 29, 2017
@JoelTroch
Apply fr-FR for OpenRCT2#1111 OpenRCT2#1114 OpenRCT2#1117 OpenRCT2#1122
1b205ef 
OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146 OpenRCT2#1162 OpenRCT2#1174
@JoelTroch JoelTroch mentioned this issue Jul 29, 2017
Merged
Goddesen pushed a commit to Goddesen/OpenRCT2-Localisation that referenced this issue Jul 30, 2017
nb-NO: Apply OpenRCT2#1146
6a41946
@Goddesen Goddesen mentioned this issue Jul 30, 2017
Merged
Gymnasiast pushed a commit that referenced this issue Jul 30, 2017
@Gymnasiast
nb-NO: Apply #1146
dc03d44
Gymnasiast pushed a commit that referenced this issue Jul 30, 2017
@JoelTroch @Gymnasiast
Apply fr-FR for #1111 #1114 #1117 #1122 #1129 #1133 #1138 #1146 #1162 #…
d470e2f 
…1174
@renansimoes renansimoes mentioned this issue Aug 2, 2017
Merged
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@octaroot @Nubbie
cs-CZ: Apply OpenRCT2#1146
5128521
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@Gymnasiast @Nubbie
nl-NL: Apply OpenRCT2#1146
494178c
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@telk5093 @Nubbie
ko-KR: Apply OpenRCT2#1146
fab590a
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@LucaRed @Nubbie
it-IT: apply OpenRCT2#1138 and OpenRCT2#1146
fed6b9b 
it-IT: apply OpenRCT2#1138 and OpenRCT2#1146
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@izhangfei @Nubbie
zh-CN: Apply OpenRCT2#1105 OpenRCT2#1108 OpenRCT2#1111 OpenRCT2#1114 O…
b2e39f0 
…penRCT2#1117 OpenRCT2#1122 OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@Wirlie @Nubbie
es-ES: Apply OpenRCT2#1111 OpenRCT2#1114 OpenRCT2#1117 OpenRCT2#1122 O…
090f4e3 
…penRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@danidoedel @Nubbie
de-DE: Apply OpenRCT2#1146
1ce69f1
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@daihakken @Nubbie
zh-TW: cumulative update, part 2
07dc937 
resolve OpenRCT2#1146, OpenRCT2#1108, OpenRCT2#1117
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@J0anJosep @Nubbie
ca-ES: Apply OpenRCT2#1086 OpenRCT2#1105 OpenRCT2#1108 OpenRCT2#1111 O…
c15e261 
…penRCT2#1114 OpenRCT2#1117 OpenRCT2#1122 OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146 OpenRCT2#1162
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@Nubbie
nb-NO: Apply OpenRCT2#1146
9b8cf0b
Nubbie pushed a commit to Nubbie/Nubbie-Localisation that referenced this issue Aug 27, 2017
@JoelTroch @Nubbie
Apply fr-FR for OpenRCT2#1111 OpenRCT2#1114 OpenRCT2#1117 OpenRCT2#1122
be343cb 
OpenRCT2#1129 OpenRCT2#1133 OpenRCT2#1138 OpenRCT2#1146 OpenRCT2#1162 OpenRCT2#1174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changed field
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gymnasiast @spacek531 @octaroot @Nubbie