Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localisations for wall-clock time based autosaving #254

Merged
merged 1 commit into from
Oct 3, 2015
Merged

Update localisations for wall-clock time based autosaving #254

merged 1 commit into from
Oct 3, 2015

Conversation

Overv
Copy link
Contributor

@Overv Overv commented Oct 3, 2015

Translations are based on strings 1879 to 1885, so they should all be correct assuming these were already correct. I've had Dutch, German and French native speakers check the strings.

Translations are based on strings 1879 to 1885, so they should all
be correct assuming these were already correct.
@Gymnasiast
Copy link
Member

Would you take out all non-checked languages, please? We prefer actual translations, not guesses or Google Translated strings.

@Overv
Copy link
Contributor Author

Overv commented Oct 3, 2015

They are not guesses. They were copied from 1879 to 1885, which are the exact same source strings, except with different minute counts.

STR_1879    :Every 10 minutes
STR_1880    :Every 20 minutes
STR_1881    :Every 30 minutes
STR_1882    :Every 45 minutes
STR_1883    :Every hour
STR_1884    :Every 2 hours
STR_1885    :Never
...
STR_2701    :Every minute
STR_2702    :Every 5 minutes
STR_2703    :Every 15 minutes
STR_2704    :Every 30 minutes
STR_2705    :Every hour
STR_2706    :Never

But I can leave only the US, Dutch, German and French ones if necessary.

Edit: The Swedish one has been confirmed as well.

@Overv
Copy link
Contributor Author

Overv commented Oct 3, 2015

Let me know if you think it's best to remove the non-confirmed ones and wait for native speakers here to handle them.

@Gymnasiast
Copy link
Member

In that case I'll assume they are correct. Thanks for the explanation.

Gymnasiast added a commit that referenced this pull request Oct 3, 2015
Update localisations for wall-clock time based autosaving
@Gymnasiast Gymnasiast merged commit 3b88b3c into OpenRCT2:master Oct 3, 2015
@Gymnasiast
Copy link
Member

OK, I merged them. Thanks for the PR. The updated strings will be in the game at 05:00 CEST.

@Overv
Copy link
Contributor Author

Overv commented Oct 3, 2015

Sorry for not being clear enough about it upfront. I realise that "based on" sounds a little unreliable.

@Gymnasiast
Copy link
Member

Sure, but I have to admit I didn't check what strings 1879 to 1885 were either. Anyway, thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants