Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairground organ style + 2 #26

Merged
merged 24 commits into from May 6, 2023
Merged

Fairground organ style + 2 #26

merged 24 commits into from May 6, 2023

Conversation

karst
Copy link
Member

@karst karst commented Mar 31, 2023

This PR will add the first songs for the replacement of the original fairground organ style.

It will also create an entirely new fairground organ style, new music for our ears! I imagine a number 3 will come and maybe more in the future :)

Fairground organ style 2 consists of 60 minutes and 30 seconds of new music from the original RCT organ.

photo_2023-04-01_00-14-13

This is not a replacement, but rather an addition. I will record more for the replacement on another date, is the planning.
@karst
Copy link
Member Author

karst commented Mar 31, 2023

What's left to do is figuring out all the names for the songs. Hopefully a friend of Herman can help me out. And otherwise the community.

@karst karst marked this pull request as ready for review March 31, 2023 22:11
@karst
Copy link
Member Author

karst commented Mar 31, 2023

Audio is quieter than the original master, do I need to turn it up a bit? Normalize the audio at least or should i push it more against the ceiling similar to the original master?

@Gymnasiast
Copy link
Member

Gymnasiast commented Apr 1, 2023

Ok, if I understand correctly, this is just a selection of the songs that the organ has, right? I’m missing a few that I saw on the Tom Gavioli channel, but if I read the description correctly, those could be in part 3?

1.flac seems to have some talking in the background (around 0:10). 3.flac and 11.flac have this too.

10.flag is “Unter dem Doppeladler” from Josef Franz Wagner.

17.flac is the Colonel Bogey March, but it looks like that one was already identified.

Regrettably, I have not been able to identify any more.

@karst
Copy link
Member Author

karst commented Apr 1, 2023

What should I do with the recordings that have a light background talk? I thought i'd leave it in since it'd mix with the other noises of the park anyhow and it wouldn't be noticable. But if it's too much of an annoyance i'll leave the songs out. I'll make sure to edit 10 to have the right name.

And you are indeed correct, these are from three of the several books the organ has.

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do with the recordings that have a light background talk?

On my lousy speakers I could barely distinguish it.

I don't know how to help identifying, so I used google voice assistant and had no luck other than identifying 10 and 17 (which were already identified)

@karst
Copy link
Member Author

karst commented Apr 11, 2023

Thanks for checking! I hope once we've got this merged the community might let us know.

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you intend to add more stuff here, but it looks good as is for me.

@karst
Copy link
Member Author

karst commented Apr 12, 2023

I don't have any more recordings. I only have the two from the original + this playlist. In next recording session I might make a third playlist. Should help a lot of with making for different tunes in the soundscape of the park.

@karst karst added the 0.4.6 Wait for 0.4.5 to be released before merging. label Apr 19, 2023
openrct2.music.cover.json Show resolved Hide resolved
openrct2.music.cover.json Outdated Show resolved Hide resolved
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
openrct2.music.cover.json Outdated Show resolved Hide resolved
openrct2.music.cover.json Outdated Show resolved Hide resolved
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
openrct2.music.cover.json Outdated Show resolved Hide resolved
@karst karst requested a review from IntelOrca May 5, 2023 22:33
@karst karst merged commit b8f33be into OpenRCT2:master May 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4.6 Wait for 0.4.5 to be released before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants