Reorganise the order of shortcut keys in the Shortcut Keys window

[guljam]

(Sorry for the new PR. I did not know how to initialize the modified remote repository, so I created a new branch.)

Re-ordered default shortcuts like vanilla RCT2
This version considers the shortcut arrangement of plugins.

The plugin's shortcut keys have a 'orderIndex' value of -1 by default and are sorted in the same way as in the previous version.
The 'orderIndex' of default shortcut starts from 0 and follows the order defined in ShortcutOrder.

You can still change the shortcut order by change the lines of elements in the "std::vector shortcutOrder" of the ShortcutManager::RegisterDefaultShortcuts() function.

I don't understand what @IntelOrca said before "set 'orderIndex' to 10 or 100". So I sorted by index numbering primitively.

old:

new:

[guljam]

@Broxzier I was trying to fix the code you suggested
I found that my code is completely ignoring the data in the reset keys.

so I restore the code for the ShortcutManager::RegisterDefaultShortcuts function to the previous version and
I simply entered the orderindex in the last parameter.

This method is very tricky when changing the order of the code.
@IntelOrca expects that shortcuts will rarely change order, so I hardcoded them.

[Broxzier]

Looks like the priorities are incrementing by one per shortcut. Why not store a variable, possible even inside the RegisterShortcut function, and let that handle the order. That saves a lot of magic numbers here.

[guljam]

Looks like the priorities are incrementing by one per shortcut. Why not store a variable, possible even inside the RegisterShortcut function, and let that handle the order. That saves a lot of magic numbers here.

that's good idea.
I was stupid.
Just by doing Orderindex++, it is expected that the shortcut keys of the plugin will be sorted well. Let's fix the code.

[guljam]

@Broxzier
I've found an optimized solution with your suggestion and the behavior is:

1. When ShortcutManager::RegisterShortcut is called, the shortcut's OrderIndex is given Shortcuts.size() -1
2. When the InitialiseList() function of shortcutKeys.cpp is called, the list is reorderd by OrderIndex

The plugin shortcuts work nice too.
The order in which ShortcutManager::RegisterShortcut is called has become important.

[Broxzier]

Please clean up this PR and mark comments as resolved if they have been addressed.

[guljam]

Please clean up this PR and mark comments as resolved if they have been addressed.
Added "// clang-format on" comment to last line.

[tupaschoal]

@guljam would you mind marking the conversations that finished as resolved?

[guljam]

@tupaschoal Oh, sorry. Does the conversation always have to end?

[tupaschoal]

@tupaschoal Oh, sorry. Does the conversation always have to end?

We tend to assume that if it's open, it's because one of the parties involved is waiting for an action (a response, a fix, etc). When it is just a suggestion that maps directly to changing the code, then it becomes outdated and it's easy to see that it has been solved and mark as such. When it's a more abstract suggestion/comment, you're always free to ask the commenter whether they like the solution or to clarify, and this is when it stays unresolved.

[Broxzier]

I've now squashed and rebased this PR. I'll get to testing this and checking over the changes again soon.

[ZehMatt]

Tested and works as expected