Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guests recoil from tile edge on path OUTSIDE park, unable to leave or enter #17897

Closed
cheweytoo opened this issue Aug 25, 2022 · 12 comments · Fixed by #17943
Closed

guests recoil from tile edge on path OUTSIDE park, unable to leave or enter #17897

cheweytoo opened this issue Aug 25, 2022 · 12 comments · Fixed by #17943
Assignees
Labels
bug Something went wrong. investigate Not sure what the problem is yet.

Comments

@cheweytoo
Copy link

Operating System

Ubuntu Linux 20.04.04

OpenRCT2 build

develop 83e4277

Describe the issue

See attached park (not a zip, just renamed to attach), it is kind of a minimal case: Guests leaving cannot leave the map, guests arriving don't enter the park.

They behave as if encountering a "no entry" sign on the edge of the tile in both directions.

The issue does NOT occur with exactly the same savegame file in 0.4.1 release. I have first noticed the issue in 83e4277, but am not sure how far back it goes.

I have not been able to reproduce this behaviour "from scratch".

Area(s) with issue?

No response

Steps to reproduce

  1. open attached park
  2. watch guests stuck right outside the entrance/not coming in

Attachments

no_one_enters_no_one_leaves.park.zip

@cheweytoo cheweytoo added the bug Something went wrong. label Aug 25, 2022
@cheweytoo
Copy link
Author

short screen recording:

no_one_enters_no_one_leaves.mp4

@Gymnasiast
Copy link
Member

When I load that file, it works without issue. Do you have any plugins installed? If so, please uninstall them (temporarily) and see if the issue persists.

@Gymnasiast Gymnasiast added the investigate Not sure what the problem is yet. label Aug 25, 2022
@cheweytoo
Copy link
Author

Oooh, I forgot about the plugins, sorry.

I renamed the plugin directory (and verified none of the plugins' menus show up in the UI): No change, my guests still recoil.

I just went through some of the older dev builds:

Issue already exists in 3e378e9, f9bb5b2, 6aabe38 and adc51ad (49215a5 and older from https://openrct2.org/downloads/develop fail to launch). Is there a way to get to even older dev builds? I'd be happy to do additional bisecting.

@karst
Copy link
Member

karst commented Aug 26, 2022

the park wont open for me, and the video wont load either. But I am curious if it is the same issue I ran into. I don't know if this is the case. If you have a path that goes up by two units in a location that has construction rights it counts as park property. I originally had that issue here.
image

@lalip
Copy link
Contributor

lalip commented Aug 26, 2022

It's one of the scenarios from vanilla RCT2, so I imagine it's not the same issue.

The video wouldn't play for me either for some reason, so I messed about with ffmpeg until it did:
https://user-images.githubusercontent.com/25644992/186797351-61adbf1b-f7e1-4fa9-be2d-e6f9e45c2241.mp4

@cheweytoo you can get them from the Actions tab in this repository; here's a shortcut to only those from the develop branch. If you want one from a specific commit you can get there through the ✔️ or ❌ beside its title, too. In pull requests they show up as checks.

@Gymnasiast
Copy link
Member

@karst The ".zip" is not a zip (even though my archiver happily extracted something from it), you need to change the extension to .park.

@cheweytoo
Copy link
Author

@cheweytoo you can get them from the Actions tab in this repository; here's a shortcut to only those from the develop branch.

Ah, thank you! I'm going through them right now.

@karst
Copy link
Member

karst commented Aug 26, 2022

@karst The ".zip" is not a zip (even though my archiver happily extracted something from it), you need to change the extension to .park.

Oh i see, yea it works then, there was a .park file inside which was confusing me.

The issue is Indeed that this tile
image
has construction rights owned. You need to remove that and then the peeps can leave just fine.

Image from Gyazo

@cheweytoo
Copy link
Author

Found it :-)

Last good: 7399163
First bad: 43bc0b0

@lalip
Copy link
Contributor

lalip commented Aug 27, 2022

Well, I guess all the above works out then! There's a change in the first bad build that stands out to me. Commit f0777e5 wasn't supposed to change behaviour, right?

- loc.z - LAND_HEIGHT_STEP >  surfaceElement->GetBaseZ()
+ loc.z                    >= surfaceElement->GetBaseZ() + ConstructionRightsClearanceSmall

Note:

  • LAND_HEIGHT_STEP = 16
  • ConstructionRightsClearanceSmall = 3
  • ConstructionRightsClearanceBig = 24

If loc.z - surfaceElement->GetBaseZ() is guaranteed to be a multiple of 8 I assume the latter was supposed to be used here

Now... would this be the actual cause, or does it only expose a corner case? I just reproduced this with the "own all land" cheat which I imagine OP also used; the end result does not change with which build I do it with. I'm curious as to why it's specifically that tile, too.

@Gymnasiast Gymnasiast self-assigned this Aug 31, 2022
Gymnasiast pushed a commit to Gymnasiast/OpenRCT2 that referenced this issue Aug 31, 2022
Gymnasiast pushed a commit to Gymnasiast/OpenRCT2 that referenced this issue Aug 31, 2022
@cheweytoo
Copy link
Author

That was quick, thank you!

@Gymnasiast
Copy link
Member

You’re welcome, it was a lot easier since you did the bisecting and lalip pointed out the mistake. ;-)

Gymnasiast added a commit that referenced this issue Oct 5, 2022
- Feature: [#6326] Ability to load .SV6 files from RCT Classic that have more than 9601 guests.
- Feature: [#6570, #10860, #17929] Fully support RollerCoaster Tycoon Classic as a RCT2 base install path.
- Feature: [#13634] Add ability to sell merchandise in random colours.
- Feature: [#16164] Add new track elements for Flying Coaster and Lay-Down Coaster and add paint code for more elements.
- Feature: [#16283] Added parkinfo command line tool to list objects in a save file.
- Feature: [#16662] Show a warning message when g2.dat is mismatched.
- Feature: [#17107] Ride operating settings can be set via text input.
- Feature: [#17638] Added Zero G rolls, medium loops and large corkscrews to the Hybrid and Single-Rail coasters.
- Feature: [#17821] [Plugin] Add API for track subpositions and vehicle subposition.
- Feature: [#17877] Add three real-life flying roller coaster colour schemes.
- Feature: [#17900] Add “Classic Wooden Coaster” with shallow banked turns.
- Feature: [#18057] Staff members now wait for passing or stalled vehicles before crossing railway tracks.
- Feature: [#18168] Add additional track pieces to the LIM Launched Coaster and the Looping Coaster.
- Feature: [objects#198] Add additional pirate roofs.
- Feature: [objects#205] Add additional glass roofs.
- Feature: [objects#209] Add the Steel Roller Coaster train and 2-across Inverted Train from RollerCoaster Tycoon 1.
- Feature: [#18050] Add asset pack manager and asset packs.
- Improved: [#15358] Park and scenario names can now contain up to 128 characters.
- Improved: [#15589] Numpad Enter can now be used to close text input.
- Improved: [#16819] Don’t prompt to “Save game as” when saving a loaded saved game (excepting autosaves).
- Improved: [#16840] Add support for rectangular heightmaps.
- Improved: [#17575] You can now search for Authors in Object Selection.
- Improved: [#17806] Added warning when using RCT1 objects without RCT1 linked.
- Improved: [#17868] [Plugin] You can now change active tab of a custom window programmatically.
- Improved: [#17909] Track elements that are not supported by any train are now hidden by default.
- Improved: [#17924] Improved performance when loading JSON object images from a .DAT file.
- Improved: [#17955] Modifying ratings via in-game console is now multiplayer-safe and also freezes the ratings.
- Improved: [#18177] [Plugin] Widget tooltips can now be read and changed.
- Change: [#9104] Calculate maze support costs.
- Change: [#17319] Giant screenshots are now cropped to the horizontal view-clipping selection.
- Change: [#17499] Update error text when using vehicle incompatible with TD6 and add error when using incompatible track elements.
- Change: [#17655] Lower default price for the Crooked House.
- Change: [#17745] Make maintenance cost of Mini-Golf more balanced.
- Change: [#17762] Use vertical tabs in the New Game dialog.
- Change: [#18113] Increased limit of Loan Interest in Scenario Editor to 255%.
- Fix: [#5141] Headless server is counted as a player.
- Fix: [#7466] Coaster track not drawn at tunnel exit.
- Fix: [#10535] Guests getting stuck at specific level crossings.
- Fix: [#14337] Guest blocking ride entrance after ride price changed to be unaffordable.
- Fix: [#15328] Wooden Roller Coaster incorrectly draws a railing on the first station piece (original bug).
- Fix: [#16392] Scenery on sloped surface is placed at wrong height.
- Fix: [#16476] The game sometimes crashes when demolishing a maze.
- Fix: [#17053] Crash when trying to open files under 4 bytes in length.
- Fix: [#17312] (Flying) Inline Twist appearing under the surface when placed on ground level.
- Fix: [#17339] Distorted visuals when changing scaling factor between integer numbers in OpenGL rendering mode.
- Fix: [#17394] Six-seater Hyper-Twister Trains focuses ride window camera on Car 2 rather than Car 1 (original bug).
- Fix: [#17430] Possible crash when toggling tile element visibility in multiplayer.
- Fix: [#17444] “Manta Ray” boats slowed down too much in “Ayers Rock” scenario (original bug).
- Fix: [#17503] Parks with staff with an ID of 0 have all staff windows focus on that staff.
- Fix: [#17508] Grid doesn’t disable after setting patrol area.
- Fix: [#17532] Object Selection window allows unselecting all station types.
- Fix: [#17533] Missing audio when specifying ‘--rct2-data-path’.
- Fix: [#17535] Multiplayer desync when placing rides with scenery.
- Fix: [#17541] Station style not correctly saved to TD6.
- Fix: [#17542] Stalls will autorotate towards paths outside the park.
- Fix: [#17544, #17754] Visual glitches in Invention List window.
- Fix: [#17553] Crash when moving invention list items to empty list.
- Fix: [#17571] All researched tracked rides show up as new vehicles in .park scenarios.
- Fix: [#17600] Notifications are not properly cleared when loading a park.
- Fix: [#17605] Crash when opening parks which have had objects removed externally.
- Fix: [#17639, 17735] When building upside down, the special elements list contains many items twice (original bug).
- Fix: [#17664] Unable to save after an extended period of time due to inactive ride music data leaking.
- Fix: [#17703] (undefined string) when building on invalid height.
- Fix: [#17776] “Other Parks” tab uses separate lists for SC4/SC6 and .park scenarios.
- Fix: [#17784] Colour preset RNG is biased (original bug).
- Fix: [#17788] Guests could leave queue if another guest rejoins it from the entrance building.
- Fix: [#17834] Finance window becomes blank after 4096 years.
- Fix: [#17816] Option to pause game when Steam Overlay is active is not greyed out when using the OpenGL renderer.
- Fix: [#17897] Guest can get stuck on tiles with construction rights outside the park.
- Fix: [#17904] Trees are removed at no cost to make way for ride entrance/exits.
- Fix: [#17905] The chain button in the map window is enabled for rectangular maps when (re)opened.
- Fix: [#17931] The in-game command ‘count_objects’ crashes the game.
- Fix: [#17865] With difficult guest generation, tested but unopened rides still contribute to the guest cap.
- Fix: [#17866] [Plugin] Wrong Soft Guest Cap at start of new game.
- Fix: [#17889] Peeps don’t stop at level railway crossings if approached from downhill.
- Fix: [#17980] Queue lines of track designs mess up existing queue lines if dragged through them.
- Fix: [#17959] Areas marked for dirty drawing are too large.
- Fix: [#17963] Some marketing campaigns can’t be started after Finances window tab has been on Research.
- Fix: [#17964] Sprites don’t show up on two sides of the view-clip selection.
- Fix: [#17966] Reversed steel trains do not properly import from S4.
- Fix: [#17973] Bins and lamps overlay parts of the land (original bug).
- Fix: [#18008] Steeplechase S-bends has multiple gaps visible in the tracks (original bug).
- Fix: [#18009] Visual glitch with litter at edge of sloped path.
- Fix: [#18025] Fix land ownership in Six Holland, Six Flags Magic Mountain, North America - Grand Canyon and Asia - Great Wall of China Tourism Enhancement scenarios.
- Fix: [#18026] Park rating drops to 0 with more than 32k guests, total ride excitement or intensity.
- Fix: [#18032] All non-interactive widgets (labels, groupboxes) produce sound when clicked.
- Fix: [#18035] Favourited servers don’t get their online status updated.
- Fix: [#18051] Visual glitch with Mine Ride’s large unbanked turn (original bug).
- Fix: [#18059] [Plugin] Width and height of custom window not changeable via script.
- Fix: [#18063] Guests can stop for all kinds of actions at railway crossing.
- Fix: [#18087] Bank balance is clamped to a 32-bit integer every transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong. investigate Not sure what the problem is yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants