Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wooden Wild Mouse ratings are calculated incorrectly #2070

Closed
clamburger opened this issue Oct 16, 2015 · 8 comments
Closed

Wooden Wild Mouse ratings are calculated incorrectly #2070

clamburger opened this issue Oct 16, 2015 · 8 comments
Labels
bug Something went wrong.

Comments

@clamburger
Copy link
Contributor

Loading the same save game in both RCT2 and OpenRCT2 shows drastically different ratings for the same ride.

The RCT2 ratings shown below are the closest to what the track preview says. You can download the track here.

RCT2:
scr2

OpenRCT2:
scr4

Not sure if this is related to #2064.

@clamburger
Copy link
Contributor Author

It looks like some sort of off-by-one error, as the binary representations of the numbers are very similar.

322: 101000010
393: 110001001
228: 011100100

644: 1010000100
787: 1100010011
457: 0111001001

Also, this doesn't just affect loaded games. Starting a new park and building Mouse Box will have the same incorrect ratings.

@duncanspumpkin duncanspumpkin added the bug Something went wrong. label Oct 16, 2015
@duncanspumpkin duncanspumpkin added this to the v0.0.3 - second stable milestone Oct 16, 2015
@janisozaur
Copy link
Member

would be useful to have both screens in same units (metric vs imperial)

@duncanspumpkin
Copy link
Contributor

@IntelOrca wrote test scripts for the ride ratings. I expect that will turn up some information about this.

@clamburger
Copy link
Contributor Author

@janisozaur Whoops, didn't notice. Have updated it now.

Did a bit more testing, it doesn't seem to affect all rides. Building a different Wooden Wild Mouse (Cheesy Mice) had the same issue, but an Inverted Hairpin Coaster (Hawksnest) and Suspended Swinging Coaster (Swither) did not experience the issue (stats are identical between OpenRCT2 and original)

@IntelOrca
Copy link
Contributor

So its likely to be a cause with just the wild mouse coaster type?
From what @clamburger said, it looks like its either multiplying by 2 when it shouldn't be or not dividing by 2 when it should be.

@clamburger
Copy link
Contributor Author

Tested about 75% of the coaster types and none of the others have exhibited the issue, apart from the Wooden Wild Mine Ride which is just a variant.

@clamburger clamburger changed the title Large ride rating discrepancy between OpenRCT2 and original Wooden Wild Mouse ratings are calculated incorrectly Oct 16, 2015
@e-foley
Copy link
Contributor

e-foley commented Oct 18, 2015

The rating system tends to apply penalties (g-forces too extreme, too few drops, too short a drop height, etc.) by dividing the ratings in half... Could it be that the original is applying some penalty that OpenRCT2 is not?

@duncanspumpkin
Copy link
Contributor

Fixed in the pre release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

5 participants