Avoid dereferencing map_get_path_element_at nullptr on libopenrct2 #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanspumpkin
requested changes
Oct 9, 2019
| @@ -761,7 +761,7 @@ bool Peep::Place(TileCoordsXYZ location, bool apply) | |||
| { | |||
| auto* pathElement = map_get_path_element_at(location); | |||
| TileElement* tileElement = reinterpret_cast<TileElement*>(pathElement); | |||
| if (!pathElement) | |||
| if (!tileElement) | |||
There was a problem hiding this comment.
This is already safe
There was a problem hiding this comment.
I figured it would be better to check for the tileElement as it's what will be used.
| @@ -9884,6 +9884,9 @@ void vehicle_update_crossings(const rct_vehicle* vehicle) | |||
| while (true) | |||
| { | |||
| auto* pathElement = map_get_path_element_at({ xyElement.x / 32, xyElement.y / 32, xyElement.element->base_height }); | |||
| if (pathElement == nullptr) | |||
| break; | |||
There was a problem hiding this comment.
This has already been accounted for in the function
Yeah, seems not to, I'll close it then. |
|
Good work anyway for exhausting all of the possibilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #9014