Scale shortcut #10341
Scale shortcut #10341
Conversation
|
Yes always add new strings to en-GB.txt, it is only the other languages that are updated via the localisation repository. |
|
Just needs a clang format and this will be good to go. In future stick to the commit message format. https://github.com/OpenRCT2/OpenRCT2/wiki/Commit-Messages Fixes #10305 |
|
In addition to the clang-format issues, please restore the whitespace surrounding the strings. It's there for clarity, and I'd prefer it to remain. :) |
src/openrct2/network/Network.cpp
Outdated
| @@ -31,7 +31,7 @@ | |||
| // This string specifies which version of network stream current build uses. | |||
| // It is used for making sure only compatible builds get connected, even within | |||
| // single OpenRCT2 version. | |||
| #define NETWORK_STREAM_VERSION "2" | |||
| #define NETWORK_STREAM_VERSION "3" | |||
There was a problem hiding this comment.
Unnecessary, please revert this change. This only needs changing when the change could cause two clients to run different logic and lead to them inferring different state from same input.
There was a problem hiding this comment.
Alright! thx for the info! btw is there any resources I can read to get a better understanding of how everything works,apart from the source code of course.
|
Argh could you also add an entry to the changelog. |
alright! don't worry Ima read the wiki in a bit to stop making these stupid mistakes :> |
distribution/changelog.txt
Outdated
| @@ -3,7 +3,7 @@ | |||
| - Change: [#1164] Use available translations for shortcut key bindings. | |||
| - Fix: [#10228] Can't import RCT1 Deluxe from Steam. | |||
| - Fix: [#10325] Crash when banners have no text. | |||
|
|
|||
| - Feature: [#10305] Add two shortcuts for increasing and decreasing the sacling factor. | |||
There was a problem hiding this comment.
Leave a blank line between versions. Also, there's a typo, "sacling"
distribution/changelog.txt
Outdated
| @@ -3,6 +3,7 @@ | |||
| - Change: [#1164] Use available translations for shortcut key bindings. | |||
| - Fix: [#10228] Can't import RCT1 Deluxe from Steam. | |||
| - Fix: [#10325] Crash when banners have no text. | |||
| - Feature: [#10305] Add two shortcuts for increasing and decreasing the scaling factor. | |||
There was a problem hiding this comment.
Features should be placed at the top of the changelog.
it functions normally, only thing that's missing is the shortcut name in the shortCutBindingList, right now it's empty, I could add the text to eng-gb.txt but I thought that localization would take of that, do you think I should add it?