Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11422 Add a shortcut key for disabling/enabling clearance checks #11806

Merged
merged 6 commits into from May 30, 2020
Merged

Fix #11422 Add a shortcut key for disabling/enabling clearance checks #11806

merged 6 commits into from May 30, 2020

Conversation

michielbos
Copy link
Contributor

@michielbos michielbos commented May 24, 2020

#11422

Some notes:

  • Shortcut is undefined by default (to prevent accidental cheating)
  • Shortcut was added to a new group of shortcuts along with the 'Open cheat menu' shortcut.
  • The option is set via SetCheatAction, so the little red "permission denied" box is displayed when the user has no permission, just like when using the cheat dropdown.
  • When clearance checks are disabled, an orange 'C' is displayed on the cheats button. This letter is localizable.

@AaronVanGeffen
Copy link
Member

There is currently no visual cue for whether or not clearance checks are enabled. Perhaps such an indicator should be added? Alternatively, perhaps the game can display a notification when the toggle takes place. (I believe both a news message and chat message have been suggested previously.)

@janisozaur janisozaur changed the title #11422 Added a shortcut key for disabling/enabling clearance checks. Fix #11422 Add a shortcut key for disabling/enabling clearance checks May 26, 2020
Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one naming thingy.

@AaronVanGeffen
Copy link
Member

Took the liberty to rebase this PR on top of develop; all CI checks pass now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants