Part of #9473: Create Vehicle::UpdateMotionCollisionDetection #11949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
reviewed
Jun 14, 2020
|
Question: should I change the xyz parameters to use Coords xyz? They're 16 bits, while Coords are 32 bits |
|
I guess yeah, ultimately we'll have to do it anyway, might as well do it now, the larger types shouldn't make a difference |
|
Yes it should be a coordsxyz. The size of the types doesn't matter for this. We have standardised towards 32bit as gives us room to expand in the future potentially. |
hdpoliveira
force-pushed
the
vehicle_update_9473_12
branch
from
519e0fc
to
4764bf7
Compare
tupaschoal
reviewed
Jun 14, 2020
hdpoliveira
force-pushed
the
vehicle_update_9473_12
branch
4 times, most recently
from
78a7f2a
to
38ce2d0
Compare
tupaschoal
reviewed
Jul 3, 2020
Converted from vehicle_update_motion_collision_detection
hdpoliveira
force-pushed
the
vehicle_update_9473_12
branch
from
38ce2d0
to
95ec63f
Compare
tupaschoal
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted from vehicle_update_motion_collision_detection