Refactor Tile Inspector widget definitions #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
2 times, most recently
from
311dc0f
to
44c9d24
Compare
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
from
44c9d24
to
8880f0d
Compare
|
@Broxzier Would you like some help with this? |
|
I want to merge this. Please rebase it and make it ready to merge. The rest of the refactor can be picked up in later PRs. |
This commis also fixes a few pixel-perfect alignment issues.
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
from
8880f0d
to
0d6a503
Compare
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
2 times, most recently
from
10ec5a0
to
e63b83f
Compare
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
from
e63b83f
to
0e8c4ec
Compare
Broxzier
commented
Nov 1, 2021
Broxzier
commented
Nov 1, 2021
Also fixes setting of groupbox title properly and make the list static
Broxzier
force-pushed
the
feature/TI-widget-code-cleanup
branch
from
36d4f85
to
15d4d2d
Compare
|
This PR is now ready for review. |
Gymnasiast
reviewed
Nov 1, 2021
Gymnasiast
reviewed
Nov 1, 2021
|
Fwiw, the changelog entry hasn't been moved to v0.3.5+ yet. |
|
Good catch. |
Gymnasiast
added a commit
that referenced
this pull request
Nov 7, 2021
|
Fixed in b78908c. |
Gymnasiast
added a commit
to Gymnasiast/OpenRCT2
that referenced
this pull request
Nov 21, 2021
- Improved: [OpenRCT2#12825, OpenRCT2#12869] The Tile Inspector window’s layout has been tweaked slightly. - Change: [OpenRCT2#15899] Weird bonus for path 0 - likely intended as a queue bonus (original bug). - Fix: [OpenRCT2#15138] Sometimes small scenery stays when building through it. - Fix: [OpenRCT2#15620] Placing track designs at locations blocked by anything results in wrong error message. - Fix: [OpenRCT2#15843] Tile Inspector can be resized too small. - Fix: [OpenRCT2#15844] Tile Inspector has inconsistent text colours. - Fix: [OpenRCT2#15878] Crash when opening a ride window for a corrupted vehicle. - Fix: [OpenRCT2#15908] Crash when track elements have no ride assigned. - Fix: [OpenRCT2#15919] Research status incorrectly considered for scenery when in editor modes. - Fix: [OpenRCT2#15938] Track designs of some ride types are incorrectly exported to TD6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently
a Work In Progressready for review, as part of #12329.Tasks:
Better name constants likeThey're now removedSUR_GBPBThis PR also corrects some incorrect pixel offsets, such as these:
