[Issue #9568] Replace RRC lift sounds LiftWood to match SFRC

[iking96]

Description

Proposed solution to #9568. Updates Reverser RC to have same lift sound as the Side Friction RC. Updates Compact Inverted Coaster to have the classic lift sound.

Ride	Current sound	Proposal
SLC	Friction wheels	Classic chain sound or Arrow sound
Reverser RC	Classic chain sound	Side-friction RC sound

[iking96]

Hey @Gymnasiast,

I am a having a bit of trouble debugging this failure: https://github.com/OpenRCT2/OpenRCT2/runs/1200743771

...
WARNING[../src/openrct2/ReplayManager.cpp:736 (Serialise)]: Replay network version mismatch: '0.2.6-25', expected: '0.3.1-0'
WARNING[../src/openrct2/ReplayManager.cpp:806 (CheckState)]: Different sprite checksum at tick 84547 (Replay Tick: 633) ; Saved: 33608acac467a02c8df21673c6a6a09eb22cc93d, Current: 814ea9f3f6130fc2c85b6c70de4aba46df8c4a33
For security reasons, it is not recommended to run OpenRCT2 with elevated permissions.
../test/tests/ReplayTests.cpp:101: Failure
Value of: replayManager->IsPlaybackStateMismatching() == false
  Actual: false
Expected: true
[  FAILED  ] Replay/ReplayTests.RunReplay/bpb1000Ticks, where GetParam() = testdata/replays/bpb1000Ticks.sv6r (3104 ms)
...

I believe the failure is saying this method returned false:

OpenRCT2/src/openrct2/ReplayManager.cpp

Lines 451 to 458 in d33ddab

	virtual bool IsPlaybackStateMismatching() const override
	{
	if (_mode != ReplayMode::PLAYING)
	{
	return false;
	}
	return _faultyChecksumIndex != -1;
	}

Judging by the warning proceeding the failure I believe I am hitting this branch:

OpenRCT2/src/openrct2/ReplayManager.cpp

Lines 799 to 809 in d33ddab

	if (savedChecksum.second.raw != checksum.raw)
	{
	uint32_t replayTick = gCurrentTicks - _currentReplay->tickStart;
	// Detected different game state.
	log_warning(
	"Different sprite checksum at tick %u (Replay Tick: %u) ; Saved: %s, Current: %s", gCurrentTicks,
	replayTick, savedChecksum.second.ToString().c_str(), checksum.ToString().c_str());
	_faultyChecksumIndex = checksumIndex;
	}

I think this test is re-running game scenarios and ensuring sprites are unchanged vs some golden file. I suppose the "LiftData" counts as part of the sprite and could throw its checksum off; is that your understanding as well?

What is the best way to move forward here, would I need to update something in this repo: https://github.com/OpenRCT2/replays?

[duncanspumpkin]

Replays just need to be rerecorded. I'm normally the one who does that but I won't do that until it's confirmed this fix is good to go

[Gymnasiast]

I'll try to review this this weekend.

[Gymnasiast]

Code is good.

Could you add a changelog entry?
Change: [#9568] Change lift sounds of Reverser Roller Coaster and Compact Inverted Coaster to better fitting ones. Put it between the FeatureandFix` entries.

Replays will need to be rerecorded. @duncanspumpkin could you handle that?

[tupaschoal]

Just needs replay rerecording now

[duncanspumpkin]

Replay has been rerecorded. You'll need to correct the conflict in the changelog.

[Gymnasiast]

@iking96 Could you rebase, rather than merge?

[iking96]

@iking96 Could you rebase, rather than merge?

@Gymnasiast Sorry about that, done!