Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13083: Dialog for renaming conflicting track design cropped #13124

Merged
merged 1 commit into from Oct 8, 2020
Merged

Fix #13083: Dialog for renaming conflicting track design cropped #13124

merged 1 commit into from Oct 8, 2020

Conversation

aw20368
Copy link
Contributor

@aw20368 aw20368 commented Oct 8, 2020 •
edited

Change description drawing from gfx_draw_string_centred to gfx_draw_string_centred_wrapped.

EDIT: adding before and after screenshots as requested.

Before:
ConflictingTrackDialog_old

After:
ConflictingTrackDialog

@aw20368
Fix OpenRCT2#13083: Dialog cropped
2e123e1 
Change description drawing from gfx_draw_string_centred to gfx_draw_string_centred_wrapped.
@aw20368 aw20368 mentioned this pull request Oct 8, 2020
Closed
2 tasks
@tupaschoal
Copy link
Member

I see you have a screenshot there on the issue, but can you update your pr above with before and after screenshots please?

@aw20368
Copy link
Contributor Author

aw20368 commented Oct 8, 2020

I see you have a screenshot there on the issue, but can you update your pr above with before and after screenshots please?

Sure, fixed.

tupaschoal
tupaschoal approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It was cropping a lot more than I expected ahahhaha.

Thanks!

@tupaschoal tupaschoal merged commit 119bacd into OpenRCT2:develop Oct 8, 2020
@tupaschoal tupaschoal added this to the v0.3.2 milestone Oct 8, 2020
@aw20368 aw20368 deleted the fix-13083-dialog-wrap branch October 8, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aw20368 @tupaschoal