Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GoTo loc_6D7A97 #13298

Merged
merged 13 commits into from
Nov 16, 2020
Merged

Refactor GoTo loc_6D7A97 #13298

merged 13 commits into from
Nov 16, 2020

Commits on Oct 25, 2020

  1. Refactor GoTo loc_6D7A97 

    Moved to another function; what would be a good name for it?
    @rpstester
    rpstester committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    d81220f View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2020

  1. Revert "Refactor GoTo loc_6D7A97" 

    This reverts commit d81220f.
    @rpstester
    rpstester committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    e731d2e View commit details
    Browse the repository at this point in the history

  2. transition to function and struct 

    using function for 6D7A97, using struct as return value
    @rpstester
    rpstester committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    497253f View commit details
    Browse the repository at this point in the history

  3. minor adjustments 

    and clang formatting as usual
    @rpstester
    rpstester committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    ad746cf View commit details
    Browse the repository at this point in the history

  4. backtrack goto 

    see if the problem is with my function or the goto refactor
    @rpstester
    rpstester committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    31b5e95 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Remove GoTo part 1 

    Make sure this idea works
    @rpstester
    rpstester committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    dc5e27b View commit details
    Browse the repository at this point in the history

  2. rename function to friendly name 

    Now called GetLiftHillSound after the comment within the code
    @rpstester
    rpstester committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    52dbb69 View commit details
    Browse the repository at this point in the history

  3. rename variable and clean up code 

    currentSound seemed better, as it is not always a scream
    @rpstester
    rpstester committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    7408066 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary comments 

    per best practice
    @rpstester
    rpstester committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    1f3499d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. make currentSound a reference param 

    That way, it won't wipe out the previous value, as it was doing before
    @rpstester
    rpstester committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    deee0c6 View commit details
    Browse the repository at this point in the history

  2. update clang formatting

    @rpstester
    rpstester committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    59b3f0a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. refactor two sound variables to match 

    frictionSound and screamSound are now consistent, since they're used in the same way
    @rpstester
    rpstester committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    67cc220 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. rework breaks on default scream 

    Per duncanspumpkin; I hope this is what you're looking for
    @rpstester
    rpstester committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    87f0951 View commit details
    Browse the repository at this point in the history