Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #12446 Refactor WEATHER to use strong enum #13434

Merged
merged 14 commits into from
Nov 22, 2020
Merged

closes #12446 Refactor WEATHER to use strong enum #13434

merged 14 commits into from
Nov 22, 2020

Commits on Nov 20, 2020

  1. closes #12446

    @transistive
    transistive committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    25c1927 View commit details
    Browse the repository at this point in the history

  2. fixed code formatting

    @transistive
    transistive committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    6c2d457 View commit details
    Browse the repository at this point in the history

  3. code style fixes not picked up by ./scripts/check-code-formatting

    @transistive
    transistive committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    3881d0c View commit details
    Browse the repository at this point in the history

  4. fixed wrong imports

    @transistive
    transistive committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b37de97 View commit details
    Browse the repository at this point in the history

  5. downgraded constexpr to its closest c++11 alternative

    @transistive
    transistive committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    98ce288 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Update src/openrct2/world/Climate.cpp 

    Simplified climate_is_sunny

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
    @transistive @tupaschoal
    transistive and tupaschoal committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    be77d4b View commit details
    Browse the repository at this point in the history

  2. Update src/openrct2/drawing/Weather.h 

    Fixed unintentional replacements

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
    @transistive @tupaschoal
    transistive and tupaschoal committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    4e6562c View commit details
    Browse the repository at this point in the history

  3. fixed commit suggestion merge bug

    @transistive
    transistive committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    f18ca78 View commit details
    Browse the repository at this point in the history

  4. removed droplet enumeration implementation

    @transistive
    transistive committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    3276478 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. reverted _s4 and _s6 back to using uint8_t instead of WeatherType

    @transistive
    transistive committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    fa73ab0 View commit details
    Browse the repository at this point in the history

  2. removed the weatherTypes array

    @transistive
    transistive committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    2c6998d View commit details
    Browse the repository at this point in the history

  3. changed climate_is_dry to weatherIsDry with weathertype as its argument

    @transistive
    transistive committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b8394cb View commit details
    Browse the repository at this point in the history

  4. capitalized WeatherIsDry

    @transistive
    transistive committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b29567c View commit details
    Browse the repository at this point in the history

  5. fixed original formatting in file Weather.h

    @transistive
    transistive committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    730d8b2 View commit details
    Browse the repository at this point in the history