Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #7059: Implement landscape doors on Ghost Train #13636

Merged
merged 7 commits into from Jan 10, 2021
Merged

Close #7059: Implement landscape doors on Ghost Train #13636

merged 7 commits into from Jan 10, 2021

Conversation

Gymnasiast
Copy link
Member

@Gymnasiast Gymnasiast commented Dec 23, 2020 •
edited

afbeelding

@Gymnasiast Gymnasiast changed the title Close #7059: Implement landscape door on Ghost Train Close #7059: Implement landscape doors on Ghost Train Dec 23, 2020
@Gymnasiast Gymnasiast linked an issue Dec 23, 2020 that may be closed by this pull request
Doors in land textures for ghost train rides do not appear when loading SV4 #7059
Closed
@duncanspumpkin
Copy link
Contributor

Doesn't this change all existing ghost rides i.e. sv6 and sv4?

@Gymnasiast
Copy link
Member Author

Yes, that's the whole point: the stucco and sandstone terrain edges (which were not in RCT2) should have doors for the Ghost Train.

There should not be any visual difference for regular terrain edges (like rock, ice, brown poles, black poles).

@duncanspumpkin
Copy link
Contributor

ahh okay that sounds fine then.

@duncanspumpkin duncanspumpkin merged commit 60d1e94 into OpenRCT2:develop Jan 10, 2021
@tupaschoal tupaschoal added this to the v0.3.3 milestone Jan 10, 2021
@Gymnasiast Gymnasiast deleted the feature/7059 branch January 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IntelOrca IntelOrca IntelOrca left review comments

@duncanspumpkin duncanspumpkin duncanspumpkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.

Doors in land textures for ghost train rides do not appear when loading SV4
4 participants
@Gymnasiast @duncanspumpkin @IntelOrca @tupaschoal