Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #17073: Writing out of bounds when trains have over 144 cars #17074

Merged

Conversation

Broxzier
Copy link
Member

This fixes some of the unclear "openrct2.exe openrct2.exe openrct2.exe openrct2.exe openrct2.exe" etc crash logs we've been getting. The array was not large enough to hold more than 144 cars. Now the array is long enough, and a static_assert ensures that it will stay that way or generate an error during compile time.

This fixes:

And maybe more, I went back 3 months on the issue tracker.

@Broxzier Broxzier force-pushed the bugfix/17073-corrupt-ride-window branch from 53a45b5 to c923397 Compare April 27, 2022 16:46
@Gymnasiast Gymnasiast merged commit 35915b0 into OpenRCT2:develop Apr 27, 2022
@Broxzier Broxzier deleted the bugfix/17073-corrupt-ride-window branch April 27, 2022 20:34
@Broxzier Broxzier linked an issue May 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment