Fix #11679: Facilities clipping issues

[rik-smeets]

Adjust the bounding boxes to prevent clipping issues as shown in linked issue. I also didn't notice any regression when testing in busy parks with facilities.

Resolves #11679.

[Gymnasiast]

This breaks drawing peeps that are inside facilities:

[rik-smeets]

This breaks drawing peeps that are inside facilities:

Good find, I completely forgot to test with peeps inside. I'll try to get those guys some privacy back ;-).

[rik-smeets]

Turns out I also introduced some new clipping issues with nearby supports, and peeps walking inside the facilities didn't look proper anymore. Some more bounding box debugging seems to have resolved these issues, I even didn't need to change as much as before. Could you take another look @Gymnasiast?

[Gymnasiast]

This version fixes the peeps, but now the glitch in #1972 is back again:

[rik-smeets]

This version fixes the peeps, but now the glitch in #1972 is back again:

Argh! How about changing this PR so it only resolves the other linked issue? #1972 is a lot harder and I could give that a separate go later.

[rik-smeets]

I just changed the scope of this PR to solely resolve #11679. Can this get your approval now, @Gymnasiast ?

[cheweytoo]

Awesome, that's much improved, thank you! There's just one flicker case left, for scenery in front of a stall:
From test park in #11679, in 4c218ba (a handful of commits ahead of this) on develop:

flickertree.mp4

[rik-smeets]

@cheweytoo Yes, I'm quite sure that's the same issue as #1972. It's a tricky one, which I didn't manage to fix yet, unfortunately.

[cheweytoo]

Ah, I see. Well, fingers crossed then. :-)

[cheweytoo]

The privacy screen is directional I'm afraid:

Doesn't seem to happen with every guest, and seems to happen more often with accessorised guests (hat, balloon), and only from the two "back view" directions, i.e. the directions that see the back of the stall.

unprivate_toilets.zip